New issue
Advanced search Search tips

Issue 665277 link

Starred by 1 user
Status: Fixed
Owner:
kjlubick@chromium.org
Closed: Nov 2016
Cc:
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Value selection box (second column) doesn't indicate that it is only listing some possible options

Project Member Reported by tansell@chromium.org, Nov 15 2016 
Go to https://chromium-swarm-dev.appspot.com/tasklist

Select "user" in the first box, get only the values;
 anonymous:anonymous
 none

However, if I manually write;
 user:tansell@chromium.org 

I get a bunch of tasks shown.

(Resulting in https://chromium-swarm-dev.appspot.com/tasklist?c=name&c=state&c=created_ts&c=user&f=user%3Atansell%40chromium.org&l=50&s=created_ts%3Adesc)

Either;
 * The box should show all valid options, or
 * The box should indicate that there are values not being shown which could be entered.

Comment 1 by kjlubick@google.com, Nov 15 2016

Status: Started (was: Assigned)
Showing all valid options is not feasible (Tried it, ran out of memory trying to aggregate them all [grumble, grumble, app engine])

I can update the mouseover that (incorrectly) says "these are all of the options that can be filtered on"

Comment 3 by kjlubick@google.com, Nov 16 2016

Status: Fixed (was: Started)
Live in chromium-swarm

Comment 4 by tansell@chromium.org, Nov 17 2016 

I feel like it would be better to have some type of indicator in the actual list rather than just the info in the tool tip.

Maybe just a "..." item which always appears after all other items?
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2016

Labels: merge-merged-2922
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d1c0bdc6a3011355e69f3688a79b56f9657b7c0

commit 6d1c0bdc6a3011355e69f3688a79b56f9657b7c0
Author: Avi Drissman <avi@chromium.org>
Date: Thu Nov 17 18:40:57 2016

Make sure all paths out of the dialog properly unregister observers.

BUG=665250, 629964 

Review-Url: https://codereview.chromium.org/2505443003
Cr-Commit-Position: refs/heads/master@{#432531}
(cherry picked from commit e0c94f8b3e3f6fde6fdfcf85edf69504d06a39d2)

Review URL: https://codereview.chromium.org/2507933004 .

Cr-Commit-Position: refs/branch-heads/2922@{#2}
Cr-Branched-From: 4793d9335b9ce611e2deb40863793fa785773200-refs/heads/master@{#432511}

[modify] https://crrev.com/6d1c0bdc6a3011355e69f3688a79b56f9657b7c0/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
[modify] https://crrev.com/6d1c0bdc6a3011355e69f3688a79b56f9657b7c0/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3

commit be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3
Author: kjlubick <kjlubick@google.com>
Date: Thu Nov 17 20:11:48 2016

Add informational messages to clarify what can be filtered on.

These informational messages should clarify that users can only filter
on tags and dimensions.

This adjusts the "float selected columns to the top" to sort those
floated columns in the order they are displayed.

This adds ... at the bottom of the task list to clarify that
not all options are givin for sorting tags (due to memory constraints).

This changes sort order a bit.  "none" now sorts at the bottom (like
ZZZ) which makes it less obnoxious than being in the middle.

This adds internal_ip to visually see what ip addresses have been
assigned.

BUG= 665277 , 664832 

Review-Url: https://codereview.chromium.org/2513613002

[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/botlist/bot-list-shared-behavior.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/botlist/bot-list.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/tasklist/task-list.html
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 17 2016

Labels: merge-merged-2922
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d1c0bdc6a3011355e69f3688a79b56f9657b7c0

commit 6d1c0bdc6a3011355e69f3688a79b56f9657b7c0
Author: Avi Drissman <avi@chromium.org>
Date: Thu Nov 17 18:40:57 2016

Make sure all paths out of the dialog properly unregister observers.

BUG=665250, 629964 

Review-Url: https://codereview.chromium.org/2505443003
Cr-Commit-Position: refs/heads/master@{#432531}
(cherry picked from commit e0c94f8b3e3f6fde6fdfcf85edf69504d06a39d2)

Review URL: https://codereview.chromium.org/2507933004 .

Cr-Commit-Position: refs/branch-heads/2922@{#2}
Cr-Branched-From: 4793d9335b9ce611e2deb40863793fa785773200-refs/heads/master@{#432511}

[modify] https://crrev.com/6d1c0bdc6a3011355e69f3688a79b56f9657b7c0/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
[modify] https://crrev.com/6d1c0bdc6a3011355e69f3688a79b56f9657b7c0/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
►

Sign in to add a comment