sizes failing on chromium/Linux x64 |
|||
Issue descriptionsizes failing on chromium/Linux x64 Type: build-failure Builders failed on: - Linux x64: https://build.chromium.org/p/chromium/builders/Linux%20x64
,
Nov 15 2016
fontmgr_default_linux.cc was added by https://codereview.chromium.org/2500643002 which was committed in the suspicious range (432006 - 432045).
,
Nov 15 2016
Created a revert patch https://codereview.chromium.org/2503763002/.
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbf14bb02366acf3cb250c98c10208e8f955ad53 commit cbf14bb02366acf3cb250c98c10208e8f955ad53 Author: horo <horo@chromium.org> Date: Tue Nov 15 03:48:45 2016 Revert of Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp clien… (patchset #4 id:60001 of https://codereview.chromium.org/2500643002/ ) Reason for revert: Caused failures at "sizes" check on Linux x64 bot. https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64 See crbug.com/665274 BUG= 665274 Original issue's description: > Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp client to use android fonts > > BUG= 617821 > > Committed: https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685 > Cr-Commit-Position: refs/heads/master@{#432023} TBR=bungeman@chromium.org,khushalsagar@chromium.org,bungeman@google.com,steimel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 617821 Review-Url: https://codereview.chromium.org/2503763002 Cr-Commit-Position: refs/heads/master@{#432082} [modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/app/linux/blimp_main.cc [modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/core/switches/blimp_client_switches.cc [modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/core/switches/blimp_client_switches.h [modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/skia/BUILD.gn [delete] https://crrev.com/94ff3d8045484adcb0daba7a05465edf813679a0/skia/ext/fontmgr_default_linux.cc [delete] https://crrev.com/94ff3d8045484adcb0daba7a05465edf813679a0/skia/ext/fontmgr_default_linux.h
,
Nov 22 2016
,
Jan 9 2017
The CL has re-landed with translation unit local leaky owning bare pointers instead of smart pointers which require and exit time destructor. |
|||
►
Sign in to add a comment |
|||
Comment 1 by horo@chromium.org
, Nov 15 2016