New issue
Advanced search Search tips

Issue 665274 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: ----
Type: ----



Sign in to add a comment

sizes failing on chromium/Linux x64

Project Member Reported by horo@chromium.org, Nov 15 2016

Issue description

sizes failing on chromium/Linux x64

Type: build-failure

Builders failed on: 
- Linux x64: 
  https://build.chromium.org/p/chromium/builders/Linux%20x64



 

Comment 1 by horo@chromium.org, Nov 15 2016

https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/28573/steps/sizes/logs/stdio


# Static initializers in /b/c/b/linux_clobber/src/out/Release/chrome:
# HINT: To get this list, run tools/linux/dump-static-initializers.py
# HINT: diff against the log from the last run to see what changed
# atomicops_internals_x86.cc AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86.cc AtomicOps_Internalx86CPUFeatures+0x1
# atomicops_internals_x86.cc AtomicOps_Internalx86CPUFeatures+0x2
# atomicops_internals_x86.cc _GLOBAL__sub_I_atomicops_internals_x86.cc+0x78
# atomicops_internals_x86.cc _GLOBAL__sub_I_atomicops_internals_x86.cc+0xef
# atomicops_internals_x86.cc (anonymous namespace)::google_initializer_module_atomicops_x86
# atomicops_internals_x86.cc GoogleInitializer::~GoogleInitializer()
# atomicops_internals_x86.cc __cxa_atexit@plt [registers a dtor to run at exit]
# atomicops_internals_x86.cc __dso_handle
# atomicops_internals_x86.cc __stack_chk_fail@plt
# atomicops_internals_x86.cc sqlite3WhereCodeOneLoopStart.aEndOp+0xa76
# atomicops_internals_x86.cc strcmp@plt
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x69
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xb5
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures+0x1
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc sqlite3WhereCodeOneLoopStart.aEndOp+0xa76
# atomicops_internals_x86_gcc.cc strcmp@plt
# debugallocation_shim.cc module_enter_exit_hook
# debugallocation_shim.cc (anonymous namespace)::large_alloc_threshold
# debugallocation_shim.cc TCMallocGuard::TCMallocGuard()
# debugallocation_shim.cc TCMallocGuard::~TCMallocGuard()
# debugallocation_shim.cc FLAG__namespace_do_not_use_directly_use_DECLARE_int64_instead::FLAGS_tcmalloc_large_alloc_report_threshold
# debugallocation_shim.cc __cxa_atexit@plt [registers a dtor to run at exit]
# debugallocation_shim.cc __dso_handle
# fontmgr_default_linux.cc (anonymous namespace)::g_default_fontmgr
# fontmgr_default_linux.cc cc::DecodedDrawImage::~DecodedDrawImage()
# fontmgr_default_linux.cc __cxa_atexit@plt [registers a dtor to run at exit]
# fontmgr_default_linux.cc __dso_handle
# ic.cc std::ios_base::Init::Init()@plt
# ic.cc std::__ioinit [#includes <iostream>, use <ostream> instead]
# ic.cc __cxa_atexit@plt [registers a dtor to run at exit]
# ic.cc __dso_handle
# ic.cc __init_array_end+0x600
# memory_region_map.cc libpthread_initialized
# spinlock.cc _GLOBAL__sub_I_spinlock.cc+0x12
# spinlock.cc NumCPUs()
# spinlock.cc adaptive_spin_count
# spinlock_internal.cc _GLOBAL__sub_I_spinlock_internal.cc+0x71
# spinlock_internal.cc have_futex
# spinlock_internal.cc futex_private_flag
# spinlock_internal.cc syscall@plt
# Found 43 static initializers in 8 files.

RESULT chrome: chrome= 172618192 bytes
RESULT chrome-stripped: stripped= 121836072 bytes
RESULT chrome-text: text= 116533585 bytes
RESULT chrome-data: data= 5295896 bytes
RESULT chrome-bss: bss= 1074408 bytes
RESULT chrome-si: initializers= 8 files
RESULT chrome-textrel: textrel= 0 relocs

# Static initializers in /b/c/b/linux_clobber/src/out/Release/nacl_helper:
# HINT: To get this list, run tools/linux/dump-static-initializers.py
# HINT: diff against the log from the last run to see what changed
# atomicops_internals_x86.cc AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86.cc AtomicOps_Internalx86CPUFeatures+0x1
# atomicops_internals_x86.cc AtomicOps_Internalx86CPUFeatures+0x2
# atomicops_internals_x86.cc _GLOBAL__sub_I_atomicops_internals_x86.cc+0x78
# atomicops_internals_x86.cc _GLOBAL__sub_I_atomicops_internals_x86.cc+0xef
# atomicops_internals_x86.cc _IO_stdin_used+0xd48
# atomicops_internals_x86.cc (anonymous namespace)::google_initializer_module_atomicops_x86
# atomicops_internals_x86.cc GoogleInitializer::~GoogleInitializer()
# atomicops_internals_x86.cc __cxa_atexit@plt [registers a dtor to run at exit]
# atomicops_internals_x86.cc __dso_handle
# atomicops_internals_x86.cc __stack_chk_fail@plt
# atomicops_internals_x86.cc strcmp@plt
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x69
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xb5
# atomicops_internals_x86_gcc.cc _IO_stdin_used+0xd48
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures+0x1
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# debugallocation_shim.cc module_enter_exit_hook
# debugallocation_shim.cc (anonymous namespace)::large_alloc_threshold
# debugallocation_shim.cc TCMallocGuard::TCMallocGuard()
# debugallocation_shim.cc TCMallocGuard::~TCMallocGuard()
# debugallocation_shim.cc FLAG__namespace_do_not_use_directly_use_DECLARE_int64_instead::FLAGS_tcmalloc_large_alloc_report_threshold
# debugallocation_shim.cc __cxa_atexit@plt [registers a dtor to run at exit]
# debugallocation_shim.cc __dso_handle
# fontmgr_default_linux.cc (anonymous namespace)::g_default_fontmgr
# fontmgr_default_linux.cc sk_sp<SkFontMgr>::~sk_sp()
# fontmgr_default_linux.cc __cxa_atexit@plt [registers a dtor to run at exit]
# fontmgr_default_linux.cc __dso_handle
# ic.cc std::ios_base::Init::Init()@plt
# ic.cc std::__ioinit [#includes <iostream>, use <ostream> instead]
# ic.cc __cxa_atexit@plt [registers a dtor to run at exit]
# ic.cc __dso_handle
# ic.cc __init_array_end+0x420
# memory_region_map.cc libpthread_initialized
# spinlock.cc _GLOBAL__sub_I_spinlock.cc+0x12
# spinlock.cc NumCPUs()
# spinlock.cc adaptive_spin_count
# spinlock_internal.cc _GLOBAL__sub_I_spinlock_internal.cc+0x71
# spinlock_internal.cc have_futex
# spinlock_internal.cc futex_private_flag
# spinlock_internal.cc syscall@plt
# Found 43 static initializers in 8 files.

RESULT nacl_helper: nacl_helper= 4337080 bytes
RESULT nacl_helper-stripped: stripped= 3433312 bytes
RESULT nacl_helper-text: text= 3386452 bytes
RESULT nacl_helper-data: data= 40936 bytes
RESULT nacl_helper-bss: bss= 207424 bytes
RESULT nacl_helper-si: initializers= 8 files
RESULT nacl_helper-textrel: textrel= 0 relocs
RESULT nacl_helper_bootstrap: nacl_helper_bootstrap= 9766 bytes
RESULT nacl_helper_bootstrap-stripped: stripped= 8848 bytes
RESULT nacl_helper_bootstrap-text: text= 6350 bytes
RESULT nacl_helper_bootstrap-data: data= 40 bytes
RESULT nacl_helper_bootstrap-bss: bss= 4113 bytes
RESULT nacl_helper_bootstrap-si: initializers= 0 files
RESULT nacl_helper_bootstrap-textrel: textrel= 0 relocs
RESULT nacl_irt_x86_64.nexe: nacl_irt_x86_64.nexe= 3737136 bytes
RESULT resources.pak: resources.pak= 17323927 bytes
RESULT totals-bss: bss= 1285945 bytes
RESULT totals-data: data= 5336872 bytes
RESULT totals-initializers: initializers= 16 files
RESULT totals-size: size= 198026101 bytes
RESULT totals-stripped: stripped= 125278232 bytes
RESULT totals-text: text= 119926387 bytes
RESULT totals-textrel: textrel= 0 relocs
<Thread(Thread-1, started 139917573666560)> ProcessRead: proc.stdout finished.
<Thread(Thread-1, started 139917573666560)> ProcessRead: cleaning up.
<Thread(Thread-2, started daemon 139917565273856)> TimedFlush: Finished
<Thread(Thread-1, started 139917573666560)> ProcessRead: finished.
Stopping Xvfb with pid 26835 ...
Xvfb pid file removed
1 new files were left in /tmp: Fix the tests to clean up themselves.
 killed dbus-daemon with PID 26831
 cleared DBUS_SESSION_BUS_ADDRESS environment variable
Command ['/usr/bin/python', u'/b/rr/tmpkEs2u5/rw/checkout/infra/.recipe_deps/build/scripts/tools/runit.py', '--show-path', '/usr/bin/python', u'/b/rr/tmpkEs2u5/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py', '--target', 'Release', '--xvfb', '--builder-name', u'Linux x64', '--slave-name', u'build48-m1', '--build-number', '28573', '--build-properties', '{"buildnumber": 28573, "slavename": "build48-m1", "target_platform": "linux", "mastername": "chromium", "buildername": "Linux x64"}', '--test-type', 'sizes', '--run-python-script', '/b/c/b/linux_clobber/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py', '--json', '/tmp/tmpwUcBEl'] returned exit code 0
FAILED linux-release-64/sizes/nacl_helper-si/initializers: actual 8, expected 7, better lower
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7, better lower
step returned non-zero exit code: 1

Comment 2 by horo@chromium.org, Nov 15 2016

fontmgr_default_linux.cc was added by https://codereview.chromium.org/2500643002 which was committed in the suspicious range (432006 - 432045).

Comment 3 by horo@chromium.org, Nov 15 2016

Created a revert patch https://codereview.chromium.org/2503763002/.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbf14bb02366acf3cb250c98c10208e8f955ad53

commit cbf14bb02366acf3cb250c98c10208e8f955ad53
Author: horo <horo@chromium.org>
Date: Tue Nov 15 03:48:45 2016

Revert of Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp clien… (patchset #4 id:60001 of https://codereview.chromium.org/2500643002/ )

Reason for revert:
Caused failures at "sizes" check on Linux x64 bot.

https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64

See  crbug.com/665274 

BUG= 665274 

Original issue's description:
> Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp client to use android fonts
>
> BUG= 617821 
>
> Committed: https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685
> Cr-Commit-Position: refs/heads/master@{#432023}

TBR=bungeman@chromium.org,khushalsagar@chromium.org,bungeman@google.com,steimel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 617821 

Review-Url: https://codereview.chromium.org/2503763002
Cr-Commit-Position: refs/heads/master@{#432082}

[modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/app/linux/blimp_main.cc
[modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/core/switches/blimp_client_switches.cc
[modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/blimp/client/core/switches/blimp_client_switches.h
[modify] https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53/skia/BUILD.gn
[delete] https://crrev.com/94ff3d8045484adcb0daba7a05465edf813679a0/skia/ext/fontmgr_default_linux.cc
[delete] https://crrev.com/94ff3d8045484adcb0daba7a05465edf813679a0/skia/ext/fontmgr_default_linux.h

Comment 5 by ajha@chromium.org, Nov 22 2016

Labels: M-56
Status: Fixed (was: Available)
The CL has re-landed with translation unit local leaky owning bare pointers instead of smart pointers which require and exit time destructor.

Sign in to add a comment