New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665271 link

Starred by 1 user
Status: Duplicate
Merged: issue 681624
Owner:
█ shunhsingou@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
akahuang@chromium.org
█ chuntsen@chromium.org
█ shunhsingou@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Factory: Clean up logs

Project Member Reported by hungte@chromium.org, Nov 15 2016 
Currently factory.log contains lots of garbage output.

Please try to clean up the logs so it contains really helpful information.

I believe this would be easier in future by Ear's modular improvements, for example

 [ERROR] goofy charge_manager.py:90 2016-11-09 07:08:08.414 Unable to set charge state: Unable to set charge state: EC returned error 1

should be eliminated, or merged / controlled by settings to turn on/off plugin logs

Comment 1 by kitching@chromium.org, Jan 16 2017

Owner: shunhsingou@chromium.org
Seems like an overall "code quality" goal for factory codebase, improving logic of when Python logging functions are called, throttling them in cases of failure, etc.

Perhaps the Goofy Plugin system can help.  In the case of "critical failures" (like for Charge Manager, unable to access EC), the plugin can simply stop so error messages are no longer printed.

Earl, what do you think about this idea?

Comment 2 by shunhsingou@chromium.org, Jan 17 2017

Mergedinto: 681624
Status: Duplicate (was: Untriaged)
Mark this a duplication of 681624, and move the discussion there.
►

Sign in to add a comment