There was recently reported that few devices didn't get WP enabled properly. Some were due to loosen WP screw, some were suspected to be factory flow problem.

I downloaded few factory logs from CPFE, and found that currently we don't have anything about gooftool results.

In fact, the log I've checked ends here:

GoogleRequiredTests.Finalize> [INFO] GoogleRequiredTests.Finalize finalize.py:417 2016-11-09 07:07:58.436 Enforced release channels: ['stable'].
GoogleRequiredTests.Finalize> [INFO] GoogleRequiredTests.Finalize factory.py:230 2016-11-09 07:07:58.437 Running gooftool: gooftool -v 4 finalize -i 3 --upload_method "shopfloor:http://XXXX/#XXX" --add_file "/var/factory/log/test_states" --enforced_release_channels stable
[ERROR] goofy charge_manager.py:90 2016-11-09 07:08:08.414 Unable to set charge state: Unable to set charge state: EC returned error 1
[ERROR] goofy charge_manager.py:90 2016-11-09 07:08:18.443 Unable to set charge state: Unable to set charge state: EC returned error 1
[ERROR] goofy charge_manager.py:90 2016-11-09 07:08:28.465 Unable to set charge state: Unable to set charge state: EC returned error 1
[ERROR] goofy charge_manager.py:90 2016-11-09 07:08:38.483 Unable to set charge state: Unable to set charge state: EC returned error 1

This is useless since most important information regarding finalization -- WP states and GBB/HWID checks, were not included.

I think we need to review the logs generated in factory flow to make sure the uploaded report looks good.

Testlog+Instalog should have this fixed, and before that's implemented, we should also fix current factory branches.