Refactor the clone for bookmark drag/drop operation in ToolbarController and TabStripController
Reported by
shahriar...@gmail.com,
Nov 15 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36 Steps to reproduce the problem: The code responsible for opening bookmarks when dragging/dropping to ToolbarController (toolbar_controller.mm -> dropURLs()) and TabStripController (tab_strip_controller.mm -> dropURLs()) is almost identical. It should be refactored for better maintainability. What is the expected behavior? What went wrong? Making changes to one part, makes it inconsistent with another one. Did this work before? N/A Chrome version: 54.0.2840.71 Channel: n/a OS Version: OS X 10.12.1 Flash Version: Shockwave Flash 23.0 r0
,
Nov 16 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7 2017
[mac triage] avial still makes sense.
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, Nov 16 2016Components: -UI UI>Browser
Labels: -Pri-2 Hotlist-CodeHealth Pri-3
Status: Available (was: Unconfirmed)