Hundreds of SPv2 layout tests started crashing for DCHECK since https://codereview.chromium.org/2489893002
Perhaps we need to rebaseline FlagExpectations/enable-slimming-paint-v2 ?
Many of them are under svg/ but saw some in compositing/ as well. Here is a sample stack trace:
[1:1:1114/175807:4779193273908:FATAL:ObjectPainter.cpp(710)] Check failed: m_layoutObject.previousPaintOffset() == adjustedPaintOffset.
#0 0x7fa925d07503 base::debug::StackTrace::StackTrace()
#1 0x7fa925d2cff1 logging::LogMessage::~LogMessage()
#2 0x7fa921b590cb blink::ObjectPainter::doCheckPaintOffset()
#3 0x7fa921b25292 blink::BlockPainter::paint()
#4 0x7fa9218e55b5 blink::LayoutBlock::paint()
#5 0x7fa921b73506 blink::PaintLayerPainter::paintFragmentWithPhase()
#6 0x7fa921b717ae blink::PaintLayerPainter::paintBackgroundForFragments()
#7 0x7fa921b71230 blink::PaintLayerPainter::paintLayerContents()
#8 0x7fa921b6fb1b blink::PaintLayerPainter::paintLayerContentsCompositingAllPhases()
#9 0x7fa921b72d59 blink::PaintLayerPainter::paintFragmentByApplyingTransform()
#10 0x7fa921b6f8dd blink::PaintLayerPainter::paintLayerWithTransform()
#11 0x7fa921b6eed1 blink::PaintLayerPainter::paintLayer()
#12 0x7fa921b71b90 blink::PaintLayerPainter::paintChildren()
#13 0x7fa921b712f6 blink::PaintLayerPainter::paintLayerContents()
#14 0x7fa921b6fb1b blink::PaintLayerPainter::paintLayerContentsCompositingAllPhases()
#15 0x7fa921b6eee7 blink::PaintLayerPainter::paintLayer()
#16 0x7fa921b71b90 blink::PaintLayerPainter::paintChildren()
#17 0x7fa921b712f6 blink::PaintLayerPainter::paintLayerContents()
#18 0x7fa921b6fb1b blink::PaintLayerPainter::paintLayerContentsCompositingAllPhases()
#19 0x7fa921b6eee7 blink::PaintLayerPainter::paintLayer()
#20 0x7fa921b6eb9f blink::PaintLayerPainter::paint()
#21 0x7fa921b3e113 blink::FramePainter::paintContents()
#22 0x7fa921b3d73b blink::FramePainter::paint()
#23 0x7fa9215dc5f7 blink::FrameView::synchronizedPaint()
#24 0x7fa9215dafec blink::FrameView::updateLifecyclePhasesInternal()
#25 0x7fa921b0044e blink::PageAnimator::updateAllLifecyclePhases()
#26 0x7fa922cbf44a blink::WebViewImpl::updateAllLifecyclePhases()
#27 0x7fa922b35d60 test_runner::WebWidgetTestClient::AnimateNow()
#28 0x7fa925d080d6 base::debug::TaskAnnotator::RunTask()
#29 0x7fa923083d04 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#30 0x7fa92308245d blink::scheduler::TaskQueueManager::DoWork()
#31 0x7fa925d080d6 base::debug::TaskAnnotator::RunTask()
#32 0x7fa925d3a541 base::MessageLoop::RunTask()
#33 0x7fa925d3a92b base::MessageLoop::DeferOrRunPendingTask()
#34 0x7fa925d3af21 base::MessageLoop::DoDelayedWork()
#35 0x7fa925d3c55d base::MessagePumpDefault::Run()
#36 0x7fa925d3a1ea base::MessageLoop::RunHandler()
#37 0x7fa925d6b5d3 base::RunLoop::Run()
#38 0x7fa926e09389 content::RendererMain()
#39 0x7fa926f5e9de content::RunZygote()
#40 0x7fa926f5f1f1 content::RunNamedProcessTypeMain()
#41 0x7fa926f5fc6a content::ContentMainRunnerImpl::Run()
#42 0x7fa926f5e536 content::ContentMain()
#43 0x00000046208a main
#44 0x7fa91e9cef45 __libc_start_main
#45 0x000000461f7d <unknown>
I'm not sure why linux_layout_tests_slimming_paint_v2 didn't catch the issue. Perhaps we used a different GN setting on the bot? Here is the GN args I use locally:
is_component_build = true
is_debug = false
dcheck_always_on = true
enable_profiling = true
Comment 1 by wangxianzhu@chromium.org
, Nov 15 2016