Download related tests in chrome_public_test_apk on Android failing on chromium.linux/Android Tests (dbg) |
||||||
Issue descriptionchrome_public_test_apk on Android failing on chromium.linux/Android Tests (dbg) Type: build-failure Builders failed on: - Android Tests (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Failed tests: org.chromium.chrome.browser.contextmenu.ContextMenuTest_testSaveDataUrl org.chromium.chrome.browser.contextmenu.ContextMenuTest_testSaveImage org.chromium.chrome.browser.contextmenu.ContextMenuTest_testSaveVideo org.chromium.chrome.browser.download.DownloadManagerServiceTest_testAllDownloadProgressIsCalledForSlowUpdates org.chromium.chrome.browser.download.DownloadManagerServiceTest_testDownloadCompletedIsCalled org.chromium.chrome.browser.download.DownloadManagerServiceTest_testDownloadFailedIsCalled org.chromium.chrome.browser.download.DownloadManagerServiceTest_testDownloadPausedIsCalled org.chromium.chrome.browser.download.DownloadManagerServiceTest_testInterruptedDownloadAreAutoResumed org.chromium.chrome.browser.download.DownloadManagerServiceTest_testInterruptedUnmeteredDownloadCannotAutoResumeOnMeteredNetwork org.chromium.chrome.browser.download.DownloadManagerServiceTest_testMultipleDownloadProgress org.chromium.chrome.browser.download.DownloadManagerServiceTest_testOnlyTwoProgressForFastUpdates org.chromium.chrome.browser.download.DownloadTest_testDangerousDownload org.chromium.chrome.browser.download.DownloadTest_testDuplicateHttpPostDownload_Download org.chromium.chrome.browser.download.DownloadTest_testHttpGetDownload org.chromium.chrome.browser.download.DownloadTest_testHttpPostDownload org.chromium.chrome.browser.download.DownloadTest_testUrlEscaping
,
Nov 15 2016
I think this CL caused this failures. https://codereview.chromium.org/2502793002
,
Nov 15 2016
Created a revert CL: https://codereview.chromium.org/2500323002/
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/350925bf0e87c2111322453618c95447f9781a03 commit 350925bf0e87c2111322453618c95447f9781a03 Author: horo <horo@chromium.org> Date: Tue Nov 15 05:41:40 2016 Revert of Fix a crash when AsyncTask cannot be scheduled while posting notification updates (patchset #2 id:20001 of https://codereview.chromium.org/2502793002/ ) Reason for revert: Caused test failures. See http://crbug.com/665257 BUG= 665257 Original issue's description: > Fix a crash when AsyncTask cannot be scheduled while posting notification updates > > When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. > In that case, we should delay the updates to next update. > > BUG=664928 > > Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c > Cr-Commit-Position: refs/heads/master@{#431934} TBR=dfalcantara@chromium.org,qinmin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664928 Review-Url: https://codereview.chromium.org/2500323002 Cr-Commit-Position: refs/heads/master@{#432118} [modify] https://crrev.com/350925bf0e87c2111322453618c95447f9781a03/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
,
Nov 15 2016
,
Nov 21 2016
Reopenning, saw more failures today: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/37461
,
Nov 21 2016
,
Nov 21 2016
Apparently the patch relanded some time ago. Should we re-revert?
,
Nov 23 2016
No failures of these tests. Mark as fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by horo@chromium.org
, Nov 15 2016