New issue
Advanced search Search tips

Issue 665257 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Download related tests in chrome_public_test_apk on Android failing on chromium.linux/Android Tests (dbg)

Project Member Reported by horo@chromium.org, Nov 15 2016

Issue description

chrome_public_test_apk on Android failing on chromium.linux/Android Tests (dbg)

Type: build-failure

Builders failed on: 
- Android Tests (dbg): 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29

Failed tests:
  org.chromium.chrome.browser.contextmenu.ContextMenuTest_testSaveDataUrl
  org.chromium.chrome.browser.contextmenu.ContextMenuTest_testSaveImage
  org.chromium.chrome.browser.contextmenu.ContextMenuTest_testSaveVideo
  org.chromium.chrome.browser.download.DownloadManagerServiceTest_testAllDownloadProgressIsCalledForSlowUpdates
  org.chromium.chrome.browser.download.DownloadManagerServiceTest_testDownloadCompletedIsCalled
  org.chromium.chrome.browser.download.DownloadManagerServiceTest_testDownloadFailedIsCalled
  org.chromium.chrome.browser.download.DownloadManagerServiceTest_testDownloadPausedIsCalled
  org.chromium.chrome.browser.download.DownloadManagerServiceTest_testInterruptedDownloadAreAutoResumed
  org.chromium.chrome.browser.download.DownloadManagerServiceTest_testInterruptedUnmeteredDownloadCannotAutoResumeOnMeteredNetwork
  org.chromium.chrome.browser.download.DownloadManagerServiceTest_testMultipleDownloadProgress
  org.chromium.chrome.browser.download.DownloadManagerServiceTest_testOnlyTwoProgressForFastUpdates
  org.chromium.chrome.browser.download.DownloadTest_testDangerousDownload
  org.chromium.chrome.browser.download.DownloadTest_testDuplicateHttpPostDownload_Download
  org.chromium.chrome.browser.download.DownloadTest_testHttpGetDownload
  org.chromium.chrome.browser.download.DownloadTest_testHttpPostDownload
  org.chromium.chrome.browser.download.DownloadTest_testUrlEscaping
 

Comment 1 by horo@chromium.org, Nov 15 2016

Looks falling in DownloadManagerService.

org.chromium.chrome.browser.contextmenu.ContextMenuTest#testSaveDataUrl (run #1):
java.lang.RuntimeException: An error occured while executing doInBackground()
	at android.os.AsyncTask$3.done(AsyncTask.java:300)
	at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:355)
	at java.util.concurrent.FutureTask.setException(FutureTask.java:222)
	at java.util.concurrent.FutureTask.run(FutureTask.java:242)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
	at java.lang.Thread.run(Thread.java:841)
Caused by: java.lang.ClassCastException: java.lang.Object[] cannot be cast to java.lang.Void[]
	at org.chromium.chrome.browser.download.DownloadManagerService$2.doInBackground(DownloadManagerService.java:665)
	at android.os.AsyncTask$2.call(AsyncTask.java:288)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	... 3 more


Comment 2 by horo@chromium.org, Nov 15 2016

Owner: qin...@chromium.org
Status: Assigned (was: Available)
I think this CL caused this failures.
https://codereview.chromium.org/2502793002

Comment 3 by horo@chromium.org, Nov 15 2016

Created a revert CL: https://codereview.chromium.org/2500323002/
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350925bf0e87c2111322453618c95447f9781a03

commit 350925bf0e87c2111322453618c95447f9781a03
Author: horo <horo@chromium.org>
Date: Tue Nov 15 05:41:40 2016

Revert of Fix a crash when AsyncTask cannot be scheduled while posting notification updates (patchset #2 id:20001 of https://codereview.chromium.org/2502793002/ )

Reason for revert:
Caused test failures.
See  http://crbug.com/665257 

BUG= 665257 

Original issue's description:
> Fix a crash when AsyncTask cannot be scheduled while posting notification updates
>
> When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail.
> In that case, we should delay the updates to next update.
>
> BUG=664928
>
> Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c
> Cr-Commit-Position: refs/heads/master@{#431934}

TBR=dfalcantara@chromium.org,qinmin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664928

Review-Url: https://codereview.chromium.org/2500323002
Cr-Commit-Position: refs/heads/master@{#432118}

[modify] https://crrev.com/350925bf0e87c2111322453618c95447f9781a03/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Comment 5 by qin...@chromium.org, Nov 15 2016

Status: Fixed (was: Assigned)

Comment 6 by piman@chromium.org, Nov 21 2016

Labels: Sheriff-Chromium
Status: Assigned (was: Fixed)
Reopenning, saw more failures today: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/37461

Comment 7 by piman@chromium.org, Nov 21 2016

Labels: Pri-1 Type-Bug

Comment 8 by piman@chromium.org, Nov 21 2016

Apparently the patch relanded some time ago. Should we re-revert?

Comment 9 by kolos@chromium.org, Nov 23 2016

Status: Fixed (was: Assigned)
No failures of these tests. Mark as fixed.

Sign in to add a comment