New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665255 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Hang in angle_translator_fuzzer

Project Member Reported by ClusterFuzz, Nov 15 2016

Issue description

Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong
Owner: cwallez@chromium.org
Status: Assigned (was: Untriaged)
Find it did not provide any possible suspect.
Suspected CLs	Findit failed to find any stack trace. Is it in a new format?

Assigning to the concern owner from the regression range, below is the CL --
https://chromium.googlesource.com/chromium/src/+log/cdafcfbc97b801a30b1b59c4944c969dee1afd99..de00b2987302ca92ad913e7a4d5379fb0eede66b?pretty=fuller

Suspecting Commit# 98bea5472ae292ed699c3ecdb7512cee1de5904a
Suspecting Review URL# https://codereview.chromium.org/2341313002

@cwallez -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Status: Started (was: Assigned)
That CL adds this new fuzzer, taking this.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/1b896c62934be40cf8a37dc28fabc15590c89a5d

commit 1b896c62934be40cf8a37dc28fabc15590c89a5d
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Nov 16 18:10:44 2016

translator: remove code related to for-loop unrolling

For loop unrolling is not used and causes the translator fuzzer to find
a hang when unrolling tons of nested loops (duh).
Also remove MMap.h which was unused.

This is essentially a revert of https://codereview.appspot.com/4331048

BUG= chromium:665255 

Change-Id: Id6940f7e306d4ed53bc992f751e9ffe733190f17
Reviewed-on: https://chromium-review.googlesource.com/412023
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[delete] https://crrev.com/5437006c8ca197a1cbdceee552a10545f4fb9918/src/compiler/translator/ForLoopUnroll.h
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/src/compiler/translator/ValidateLimitations.h
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/include/GLSLANG/ShaderLang.h
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/src/tests/compiler_tests/MalformedShader_test.cpp
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/src/compiler/translator/Compiler.cpp
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/src/compiler/translator/OutputGLSLBase.cpp
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/src/compiler/translator/OutputGLSLBase.h
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/samples/shader_translator/shader_translator.cpp
[delete] https://crrev.com/5437006c8ca197a1cbdceee552a10545f4fb9918/src/compiler/translator/MMap.h
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/src/compiler.gypi
[delete] https://crrev.com/5437006c8ca197a1cbdceee552a10545f4fb9918/src/compiler/translator/LoopInfo.cpp
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/src/compiler/translator/IntermNode.h
[delete] https://crrev.com/5437006c8ca197a1cbdceee552a10545f4fb9918/src/compiler/translator/LoopInfo.h
[modify] https://crrev.com/1b896c62934be40cf8a37dc28fabc15590c89a5d/src/compiler/translator/ValidateLimitations.cpp
[delete] https://crrev.com/5437006c8ca197a1cbdceee552a10545f4fb9918/src/compiler/translator/ForLoopUnroll.cpp

Project Member

Comment 4 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c313196cb49ecb3bb31b40b9fd64a8d63a965ad

commit 5c313196cb49ecb3bb31b40b9fd64a8d63a965ad
Author: geofflang <geofflang@chromium.org>
Date: Thu Nov 24 18:49:26 2016

Roll ANGLE 41f9f67..133a2ec

https://chromium.googlesource.com/angle/angle.git/+log/41f9f67..133a2ec

BUG= chromium:665255 , chromium:667468 

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2532553002
Cr-Commit-Position: refs/heads/master@{#434372}

[modify] https://crrev.com/5c313196cb49ecb3bb31b40b9fd64a8d63a965ad/DEPS

Project Member

Comment 6 by ClusterFuzz, Nov 25 2016

ClusterFuzz has detected this issue as fixed in range 434175:434379.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5691081263153152

Fuzzer: libfuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Hang
Crash Address: 
Crash State:
  angle_translator_fuzzer
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=420371:420478
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=434175:434379

Minimized Testcase (0.85 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97kvhBauKi7pyEYzmxi4BbLC-Rlc_3guTGooI6Y55I23KLybfs_1NvqdWEz33OOR5HLQcNrsxAdILjD709LEa70fttmsbSofXli2NPLEtak3wHQJ3vR4ex-J3jA5S--JE9kgGPK3nUr4lK0eZAv7VMi32p4Kw?testcase_id=5691081263153152

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Started)
Changing the status to Fixed, as per Comment# 6, ClusterFuzz detected the issue as fixed in the mentioned range.
Thank You.
Thanks, however isn't ClusterFuzz supposed to mark the issue fixed itself (in comment 6)?
Cc: infe...@chromium.org
Reg #8: ClusterFuzz actually does this by changing status to 'Verified' and not very sure why this case is exception for that (Might be we need to allow some more time b/n c#6 & #7 ?).

+ Abhishek for further comments.

Thank you!

Sign in to add a comment