New issue
Advanced search Search tips

Issue 665245 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 659155



Sign in to add a comment

aura::SetName and SetTitle should map to properties for aura-mus

Project Member Reported by sky@chromium.org, Nov 15 2016

Issue description

By that I mean setting the name and title of a aura::Window should go to the server so the windowmanager knows the title, and mus knows the name (for debugging).

This is related to 663522.
 

Comment 1 by msw@chromium.org, Nov 17 2016

Cc: -msw@chromium.org
Owner: msw@chromium.org
Status: Assigned (was: Untriaged)
Is it reasonable to convert these to string window properties, instead of members?

Comment 2 by sky@chromium.org, Nov 17 2016

As they aren't used on all windows, sure.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745

commit 5f2fe79fcb79b28111dcdb37e226cff0a1ee5745
Author: msw <msw@chromium.org>
Date: Fri Nov 18 06:14:32 2016

Use aura::WindowProperty for title and name strings.

Makes it easier to convert/transport these for mus.

BUG= 665245 
TEST=No window titling/naming regressions.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2502413005
Cr-Commit-Position: refs/heads/master@{#433130}

[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ash/shell/window_watcher_shelf_item_delegate.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ash/touch/touch_uma.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ash/wm/window_util.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/chrome/browser/media/webrtc/desktop_media_list_ash.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/chrome/browser/memory/tab_manager_delegate_chromeos.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/aura/client/aura_constants.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/aura/client/aura_constants.h
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/aura/window.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/aura/window.h
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/views/widget/window_reorderer_unittest.cc
[modify] https://crrev.com/5f2fe79fcb79b28111dcdb37e226cff0a1ee5745/ui/wm/public/tooltip_client.cc

Comment 5 by msw@chromium.org, Nov 21 2016

Status: Fixed (was: Assigned)
This should be fixed; let me know if anything is missing.

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment