New issue
Advanced search Search tips

Issue 665243 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Launch-OWP
Launch-Accessibility: NotReviewed
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: NotReviewed
Launch-M-Approved: ----
Launch-M-Target: 57-Stable
Launch-Privacy: NotReviewed
Launch-Security: NA
Launch-Test: NotReviewed
Launch-UI: NA
Rollout-Type: ----



Sign in to add a comment

Remove deprecated webkit-prefixed Indexed DB global aliases

Project Member Reported by jsb...@chromium.org, Nov 15 2016

Issue description

Change description:

The IndexedDB entry point and global constructors were exposed with `webkit` prefixes as was the custom at the time, circa Chrome M11. The unprefixed versions shipped in M24. Usage analysis indicates it is probably safe to remove them.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/biC_Tz7UV5Y/X5752vTvAgAJ

Changes to API surface:

* Remove webkitIndexedDB, webkitIDBKeyRange, webkitIDBCursor, webkitIDBDatabase, webkitIDBFactory, webkitIDBIndex, webkitIDBObjectStore, webkitIDBRequest, webkitIDBTransaction

Support in other browsers:
Internet Explorer: never supported webkit-prefixed aliases for these
Firefox: never supported webkit-prefixed aliases for these
Safari: never supported webkit-prefixed aliases for these

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726

commit d39b9fedfbc9f9c8dacab292e0e8937fb0aea726
Author: jsbell <jsbell@chromium.org>
Date: Thu Nov 17 06:41:15 2016

Indexed DB: Add removal date to webkit-prefixed alias deprecations

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/biC_Tz7UV5Y/X5752vTvAgAJ

R=foolip@chromium.org
BUG= 665243 

Review-Url: https://codereview.chromium.org/2501263002
Cr-Commit-Position: refs/heads/master@{#432784}

[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/dom/everything-to-string-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/fast/js/global-constructors-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-properties-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-workers-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726/third_party/WebKit/Source/core/frame/Deprecation.cpp

Comment 2 by palmer@chromium.org, Nov 17 2016

Labels: -Launch-Security-NotReviewed Launch-Security-NA
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6dd3fdcdb08217919ed76d22f00d62daea91f92

commit d6dd3fdcdb08217919ed76d22f00d62daea91f92
Author: jsbell <jsbell@chromium.org>
Date: Mon Nov 21 21:58:43 2016

Indexed DB: Remove 'webkit'-prefixed global aliases

Remove webkitIndexedDB entry point alias, as well as 'webkitIDBXyz'
aliases for the global constructors.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/biC_Tz7UV5Y/X5752vTvAgAJ
BUG= 665243 
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2501743003
Cr-Commit-Position: refs/heads/master@{#433663}

[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/dom/everything-to-string-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/fast/js/global-constructors-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-properties-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[delete] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/third_party/WebKit/LayoutTests/storage/indexeddb/removed-expected.txt
[delete] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/third_party/WebKit/LayoutTests/storage/indexeddb/removed.html
[delete] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/third_party/WebKit/LayoutTests/storage/indexeddb/resources/removed.js
[delete] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/third_party/WebKit/LayoutTests/storage/indexeddb/resources/unprefix.js
[delete] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-expected.txt
[delete] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-workers-expected.txt
[delete] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-workers.html
[delete] https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc/third_party/WebKit/LayoutTests/storage/indexeddb/unprefix.html
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/Source/modules/indexeddb/WindowIndexedDatabase.idl
[modify] https://crrev.com/d6dd3fdcdb08217919ed76d22f00d62daea91f92/third_party/WebKit/Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl

Comment 4 by jsb...@chromium.org, Mar 22 2017

Went out in 57. Resolving.

Comment 5 by jsb...@chromium.org, Mar 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment