New issue
Advanced search Search tips

Issue 665241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Add UMA for accept= on input type=file

Project Member Reported by owe...@chromium.org, Nov 15 2016

Issue description

We'd like to understand how the accept field is used on input type=file. 

Anecdotally:
- Twitter uses: "image/gif,image/jpeg,image/jpg,image/png,video/mp4,video/x-m4v"
- Facebook uses "video/*,  video/x-m4v, video/webm, video/x-ms-wmv, video/x-msvideo, video/3gpp, video/flv, video/x-flv, video/mp4, video/quicktime, video/mpeg, video/ogv, image/*"
- Imgur uses: ".jpg,.jpeg,.png,.gif,.apng,.tiff,.tif,.bmp,.pdf,.xcf,.webp"

For the purposes of deciding which file types to prioritize for a new file picker I'd like to understand what % of uploads on the web are:

- A subset of Images
- A subset of Video
- A subset of Video + Images

We hypothesize that on mobile the third bucket is a high proportion and thus building a new file picker that only supports video and images is likely sufficient for our product goals.
 
Components: Blink>Forms

Comment 2 by tkent@chromium.org, Nov 17 2016

Components: -Blink>Forms Blink>Forms>File
Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47b929861e84d93735a00b76a79faf1c40097078

commit 47b929861e84d93735a00b76a79faf1c40097078
Author: peter <peter@chromium.org>
Date: Thu Jan 26 16:09:49 2017

Record whether a file picker specialized for media content can be used

Finnur is working on a new file picker ( Issue 656015 ), and in order to
decide on a shipping plan we'd like to gather some data on whether it
would be appropriate to ship in multiple stages.

R=finnur
BUG= 665241 

Review-Url: https://codereview.chromium.org/2649033007
Cr-Commit-Position: refs/heads/master@{#446337}

[modify] https://crrev.com/47b929861e84d93735a00b76a79faf1c40097078/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/47b929861e84d93735a00b76a79faf1c40097078/ui/android/BUILD.gn
[modify] https://crrev.com/47b929861e84d93735a00b76a79faf1c40097078/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
[add] https://crrev.com/47b929861e84d93735a00b76a79faf1c40097078/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java

Comment 4 by peter@chromium.org, Jan 26 2017

Cc: -peter@chromium.org
Labels: Merge-Request-57
Owner: peter@chromium.org
Status: Started (was: Available)
This is a safe (and tested!) UMA change, which would provide super useful information for development of an in-progress file picker. May we merge this to M-57?
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 27 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 27 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f22ddf746b49176a2806e8677755bcf4e7f496a

commit 4f22ddf746b49176a2806e8677755bcf4e7f496a
Author: Peter Beverloo <peter@chromium.org>
Date: Fri Jan 27 16:18:22 2017

Record whether a file picker specialized for media content can be used

Finnur is working on a new file picker ( Issue 656015 ), and in order to
decide on a shipping plan we'd like to gather some data on whether it
would be appropriate to ship in multiple stages.

R=finnur
BUG= 665241 

Review-Url: https://codereview.chromium.org/2649033007
Cr-Commit-Position: refs/heads/master@{#446337}
(cherry picked from commit 47b929861e84d93735a00b76a79faf1c40097078)

Review-Url: https://codereview.chromium.org/2663523002 .
Cr-Commit-Position: refs/branch-heads/2987@{#145}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/4f22ddf746b49176a2806e8677755bcf4e7f496a/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/4f22ddf746b49176a2806e8677755bcf4e7f496a/ui/android/BUILD.gn
[modify] https://crrev.com/4f22ddf746b49176a2806e8677755bcf4e7f496a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
[add] https://crrev.com/4f22ddf746b49176a2806e8677755bcf4e7f496a/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java

Comment 7 by peter@chromium.org, Jan 27 2017

Status: Fixed (was: Started)

Sign in to add a comment