New issue
Advanced search Search tips

Issue 665238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Under-invalidation of animated table row/col/section background

Project Member Reported by wangxianzhu@chromium.org, Nov 15 2016

Issue description

As the title.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffeecd35f06da8881d403717e84e561b74acd87b

commit ffeecd35f06da8881d403717e84e561b74acd87b
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Nov 16 06:16:29 2016

Fix bug of animated table col/section/row background

Was to create a patch to move the background changed flag into
LayoutObject as preparation for cleanup/optimization of paint
invalidation of local attachment backgrounds, but found the bug which
needs the background flag to fix.

Besides the background changed flag change, also move handling of
mayNeedPaintInvalidationAnimatedBackground and delayed invalidation
into LayoutBox::ensureIsReadyForPaintInvalidation(), and
TablePaintInvalidator call ensureIsReadyForPaintInvalidation() for
col/section/row before checking their background changed flags.

BUG= 665238 
TEST=paint/invalidation/table/animated-row-background.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2501833002
Cr-Commit-Position: refs/heads/master@{#432380}

[add] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background-expected.txt
[add] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/LayoutTests/paint/invalidation/table/animated-row-background.html
[modify] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
[modify] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h
[modify] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
[modify] https://crrev.com/ffeecd35f06da8881d403717e84e561b74acd87b/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment