New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665229 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

opencv fails to build with latest llvm

Project Member Reported by manojgupta@chromium.org, Nov 15 2016

Issue description

OpenCV build has several errors because of pointer comparison with 0 using > operator. It should be changed to !=

OpenCV-2.3.0/modules/core/src/persistence.cpp:3437:36: 
error: ordered comparison between pointer and zero ('const char *' and 'int')
opencv-2.3.0-r5:     if( rows < 0 || cols < 0 || dt < 0 )


 
Cc: vapier@chromium.org llozano@chromium.org
Status: Assigned (was: Untriaged)
Cc: yunlian@chromium.org
Owner: manojgupta@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0ff9ba13a989c73fc887c3426d39e4db05bfbce4

commit 0ff9ba13a989c73fc887c3426d39e4db05bfbce4
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Nov 14 23:42:55 2016

Fix opencv ebuild to work with latest llvm.

Fix clang error:
ordered comparison between pointer and zero ('const char *' and 'int')
The warning was already fixed upstream.

BUG= chromium:665229 
TEST=no more error when building

Change-Id: I4cb1b6e1622872822442f99e191ecaf23eebf65c
Reviewed-on: https://chromium-review.googlesource.com/411322
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/0ff9ba13a989c73fc887c3426d39e4db05bfbce4/media-libs/opencv/files/opencv-2.3.0-clang-error.patch
[rename] https://crrev.com/0ff9ba13a989c73fc887c3426d39e4db05bfbce4/media-libs/opencv/opencv-2.3.0-r6.ebuild

Status: Fixed (was: Assigned)

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)

Sign in to add a comment