New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665225 link

Starred by 1 user
Status: Duplicate
Merged: issue 674176
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
derat@chromium.org
tbuck...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 633304


Sign in to add a comment

Enable or remove "ash-enable-tablet-power-button" switch once ready

Project Member Reported by warx@chromium.org, Nov 15 2016 
Per feature request 633304, add a switch for tablet power button behavior but not enabled yet.

Enable or remove the switch, depending how it goes on 633304.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cbb0b1f01687665a716a8797243723fab7bf71d

commit 9cbb0b1f01687665a716a8797243723fab7bf71d
Author: warx <warx@chromium.org>
Date: Tue Nov 15 18:04:30 2016

Add a switch for tablet power button behavior

Major tablet power button behavior feature is landed in M56. However, it still has several unsolved issues. Add a switch for tablet power button behavior. It is not enabled for M56.

BUG= 665225 
TEST=manual test and automate tests

Review-Url: https://codereview.chromium.org/2506493002
Cr-Commit-Position: refs/heads/master@{#432214}

[modify] https://crrev.com/9cbb0b1f01687665a716a8797243723fab7bf71d/ash/common/ash_switches.cc
[modify] https://crrev.com/9cbb0b1f01687665a716a8797243723fab7bf71d/ash/common/ash_switches.h
[modify] https://crrev.com/9cbb0b1f01687665a716a8797243723fab7bf71d/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/9cbb0b1f01687665a716a8797243723fab7bf71d/ash/wm/power_button_controller.cc
[modify] https://crrev.com/9cbb0b1f01687665a716a8797243723fab7bf71d/chrome/browser/chromeos/login/chrome_restart_request.cc

Comment 2 by warx@chromium.org, Nov 16 2016

Summary: Enable or remove "ash-enable-tablet-power-button" switch once ready (was: Temporally add a switch for tablet power button behavior)

Comment 3 by warx@chromium.org, Dec 15 2016

Mergedinto: 674176
Status: Duplicate (was: Assigned)
►

Sign in to add a comment