New issue
Advanced search Search tips

Issue 665222 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 600469



Sign in to add a comment

Trybot patch failure when deleting a file modified in a dependent patchset

Project Member Reported by nick@chromium.org, Nov 15 2016

Issue description

If you have a CL 'A' that modifies a file, and a dependent CL 'B' that removes the same file, then it is not possible to run a try job for 'B'.

What happens is that you see an error like this at the patch set:

===

While running git rm content/renderer/render_widget_fullscreen.cc;
  error: the following file has changes staged in the index:
      content/renderer/render_widget_fullscreen.cc
  (use --cached to keep the file, or -f to force removal)
Patch:  D    content/renderer/render_widget_fullscreen.cc
Index: content/renderer/render_widget_fullscreen.cc
diff --git a/content/renderer/render_widget_fullscreen.cc b/content/renderer/render_widget_fullscreen.cc
deleted file mode 100644


 

Comment 1 by estaab@chromium.org, Mar 27 2017

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
This was also reported on chromium-dev here:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/PnHhW-Vm0YE/jJAaZTpHBAAJ

This should be supported. It's probably not all that common but since it's come up a few times already bumping priority up to 2.

Comment 2 by estaab@chromium.org, Mar 27 2017

Cc: hinoka@chromium.org
Blockedon: 600469
Components: Infra>Codereview>Rietveld
KI. This is due to Rietveld's way of applying patches. Will be resolved by Gerrit, hence marking as blocked on  issue 600469 
Status: WontFix (was: Available)
Closing in bulk due to Rietveld’s deprecation in favor of Gerrit. If you feel this bug should not have been closed, please feel free to re-open.

Sign in to add a comment