Interim fix: https://codereview.chromium.org/2495213006/

Hmm.  The omnibox star and the Chrome menu button itself are both similarly-sized objects with a similar highlight, a dropdown/menu that appears on click, and a ripple effect.  But in those cases the ripple is slower, making things look less glitchy.  Can we just make the ripple here look good and be consistent with our other ripples, instead of removing it?

It seems like we're busy trying to add ripples for most of the remaining top-chrome UI elements that don't have them, so I'm a bit mystified why we want to remove some here, instead of just making sure they look nice.  What's the logic?

The highlight is supposed to remain (i.e. the rounded rectangle), the ripple (i.e. the circle) was never supposed to be there.  Adding varkha@ for reasoning as he added it in the first place.

I understood that your position was that the ripple was not supposed to be there, but I'm contesting it.  I think from a consistency and UI feedback perspective, this should have a ripple, it's just that it should have one that looks good, as e.g. the Star ripple does; and it currently doesn't.

I'd like to understand _why_ you feel the ripple is "not supposed to be there", from a design perspective.

Because no other UI elements inside a normal menu have a ripple.  The highlight is only used because it resembles the hot tracking effect used by the text rows.  So it's a question of what other elements should we be consistent with.

 Issue 664910  has been merged into this issue.

 Issue 706283  has been merged into this issue.

CL: https://codereview.chromium.org/2914043002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63422e6364f834a36ac69cc1a743ad4bcabc4c09

commit 63422e6364f834a36ac69cc1a743ad4bcabc4c09
Author: bruthig <bruthig@chromium.org>
Date: Wed May 31 23:47:47 2017

Changed extension buttons to use a flood-fill ripple when in the chrome menu.

BUG= 665214 
TEST=none

Review-Url: https://codereview.chromium.org/2914043002
Cr-Commit-Position: refs/heads/master@{#476094}

[modify] https://crrev.com/63422e6364f834a36ac69cc1a743ad4bcabc4c09/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/63422e6364f834a36ac69cc1a743ad4bcabc4c09/chrome/browser/ui/views/toolbar/toolbar_action_view.h