New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665211 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
dbeam@chromium.org
tbuck...@chromium.org
█ tkonch...@chromium.org
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: Long search engine name wrapped weirdly.

Project Member Reported by dpa...@chromium.org, Nov 14 2016 
The search engine name is wrapped below the icon, which looks odd. I don't think that was the original intention (see screenshot).
search_engine_wrap.png
18.5 KB View Download

Comment 1 by dpa...@chromium.org, Nov 18 2016

Cc: nyerramilli@chromium.org tkonch...@chromium.org dschuyler@chromium.org
 Issue 657360  has been merged into this issue.

Comment 2 by dpa...@chromium.org, Nov 18 2016 

Wrapping is weird, and alignment is wrong even when no wrapping happens, see attachment.
misaligned_text.png
5.2 KB View Download

Comment 3 by dpa...@chromium.org, Nov 18 2016

Owner: dpa...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/849bd827c5e1d6838c9b3be49785de9a4cfe945b

commit 849bd827c5e1d6838c9b3be49785de9a4cfe945b
Author: dbeam <dbeam@chromium.org>
Date: Tue Nov 22 03:47:19 2016

MD Settings: change how text wraps for long search engine titles

R=dpapad@chromium.org
BUG= 665211 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2518193002
Cr-Commit-Position: refs/heads/master@{#433778}

[modify] https://crrev.com/849bd827c5e1d6838c9b3be49785de9a4cfe945b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/849bd827c5e1d6838c9b3be49785de9a4cfe945b/chrome/test/data/webui/settings/search_engines_page_test.js

Comment 5 by dbeam@chromium.org, Nov 22 2016

Owner: dbeam@chromium.org
Status: Fixed (was: Started)
►

Sign in to add a comment