Implement updated basic card spec: https://w3c.github.io/webpayments-methods-card/#basiccardrequest
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e71bf006592c9ebba8c459848308b27e3efa63b4 commit e71bf006592c9ebba8c459848308b27e3efa63b4 Author: rouslan <rouslan@chromium.org> Date: Tue Nov 22 01:29:21 2016 Consider payment method specific data when filtering payment apps. Chrome filters payment apps by payment method, e.g., "visa", "mastercard", or "https://android.com/pay". With the upcoming implementation of the new "basic-card" payment method, the filtering needs to be based on the method specific data. The following snippet, for example, specifies the "visa" and "debit" filters inside of the method specific data. new PaymentRequest([{ supportedMethods: ['basic-card'], data: { supportedNetworks: ['visa'], supportedTypes: ['debit'] } }], shoppingCartContents); This patch adds ability to filter out payment apps based on method specific data as well as the list of payment methods that they support. BUG= 665190 Review-Url: https://codereview.chromium.org/2511953004 Cr-Commit-Position: refs/heads/master@{#433731} [modify] https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java [modify] https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/04718e1c9d8a359ac22dafdd08c874eb94a08842 commit 04718e1c9d8a359ac22dafdd08c874eb94a08842 Author: Rouslan Solomakhin <rouslan@google.com> Date: Tue Nov 22 02:04:21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e commit b1be35c4c222d904ae02ea5c5dfdf1972d031f1e Author: rouslan <rouslan@chromium.org> Date: Mon Jan 09 17:22:36 2017 Implement the new basic card specification. The basic card specification has been updated to include card types (credit, debit, prepaid), which are distinct from card networks (amex, discover, mastercard, visa, etc). This patch adds support for the new format without removing support for the old format. Parsing of the JSON data that encodes the parameters happens in the renderer for safety. Old format (still supported): new PaymentRequest([{ supportedMethods: ['visa'] }], shoppingCartContents); New format (in this patch): new PaymentRequest([{ supportedMethods: ['basic-card'], data: { supportedNetworks: ['visa'], supportedTypes: ['debit'] } }], shoppingCartContents); Basic card spec: https://w3c.github.io/webpayments-methods-card/ Intent to implement and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/IYRjdUKxCoM/8B-jp4g9AgAJ BUG= 665190 Review-Url: https://codereview.chromium.org/2501593003 Cr-Commit-Position: refs/heads/master@{#442281} [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/android/java_sources.gni [add] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBasicCardTest.java [add] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/test/data/android/payments/basic_card.js [add] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/chrome/test/data/android/payments/payment_request_basic_card_test.html [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/components/payments/payment_request.mojom [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/third_party/WebKit/LayoutTests/payments/payment-request-interface.html [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/third_party/WebKit/Source/modules/modules_idl_files.gni [add] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/third_party/WebKit/Source/modules/payments/BasicCardRequest.idl [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/b1be35c4c222d904ae02ea5c5dfdf1972d031f1e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a997405962fb2ee1a66979195cb3462e3993e355 commit a997405962fb2ee1a66979195cb3462e3993e355 Author: rouslan <rouslan@chromium.org> Date: Mon Jan 09 19:22:21 2017 Enable Basic Card payment method by default. Intent to implement and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/IYRjdUKxCoM/8B-jp4g9AgAJ Spec: https://w3c.github.io/webpayments-methods-card/ BUG= 665190 Review-Url: https://codereview.chromium.org/2619343002 Cr-Commit-Position: refs/heads/master@{#442307} [modify] https://crrev.com/a997405962fb2ee1a66979195cb3462e3993e355/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19ecf9e5eb6535ea565099f8888f45e707337824 commit 19ecf9e5eb6535ea565099f8888f45e707337824 Author: rouslan <rouslan@chromium.org> Date: Mon Jan 09 20:28:46 2017 Re-enable MIR card issuer network in web payments. The http://crrev.com/2501593003 patch accidentally removed support for MIR card issuer network in web payments API. This patch re-enables it. List of issuer networks: https://github.com/w3c/webpayments/blob/gh-pages/proposals/supported-networks-list.md BUG= 665190 Review-Url: https://codereview.chromium.org/2621683002 Cr-Commit-Position: refs/heads/master@{#442327} [modify] https://crrev.com/19ecf9e5eb6535ea565099f8888f45e707337824/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/19ecf9e5eb6535ea565099f8888f45e707337824/components/payments/payment_request.mojom [modify] https://crrev.com/19ecf9e5eb6535ea565099f8888f45e707337824/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9558d815524be81ef126226d4ad420b9f9987c21 commit 9558d815524be81ef126226d4ad420b9f9987c21 Author: Eric Willigers <ericwilligers@chromium.org> Date: Thu Aug 09 02:07:44 2018 Retire PaymentRequestBasicCard flag Support for basic card payment method specification shipped in M57. https://codereview.chromium.org/2501593003 https://www.chromestatus.com/feature/5408502604365824 BUG= 665190 Change-Id: I29780c35a6ccf5c9d5a94b21e38d8605ba8b77f9 Reviewed-on: https://chromium-review.googlesource.com/1166744 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581754} [modify] https://crrev.com/9558d815524be81ef126226d4ad420b9f9987c21/third_party/blink/renderer/modules/payments/payment_request.cc [modify] https://crrev.com/9558d815524be81ef126226d4ad420b9f9987c21/third_party/blink/renderer/platform/runtime_enabled_features.json5
Comment 1 by bugdroid1@chromium.org
, Nov 22 2016