Issue 665186 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ waihong@chromium.org Last visit > 30 days ago
Closed:	Dec 2016
Cc:	dchan@chromium.org tbroch@chromium.org █ vbendeb@chromium.org nsanders@chromium.org █ kevcheng@chromium.org adurbin@chromium.org
Components:	OS>Firmware
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
servov4 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Servo v4: Start servod with asking user if only one servo v4 and one servo-micro (or CCD endpoint)

Project Member Reported by waihong@chromium.org, Nov 14 2016

Issue description

Vadim mentioned it in the meeting. Like a normal development environment, only one servo v4 and one servo-micro (or CCD endpoint), now servod asks user to choose, like:

$ sudo servod -b gru
2016-11-14 14:04:40,968 - servod - INFO - Start
2016-11-14 14:04:42,082 - servod - INFO - Found servo, vid: 0x18d1 pid: 0x5014 sid:
2016-11-14 14:04:42,085 - servod - INFO - Found servo, vid: 0x18d1 pid: 0x501b sid: ND00210
2016-11-14 14:04:42,085 - servod - INFO - 
2016-11-14 14:04:43,086 - servod - INFO - Press '0' for servo, vid: 0x18d1 pid: 0x5014 sid:
2016-11-14 14:04:43,088 - servod - INFO - Press '1' for servo, vid: 0x18d1 pid: 0x501b sid: ND00210
2016-11-14 14:04:53,095 - servod - WARNING - Timed out waiting for your choice

We should filter the servo-micro (or CCD) in this case and start the servo v4. The servo-micro (or CCD) will be initialized in the post_init phase afterward.

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/5dfec2e14315abdaaa4a4a9fdedb3e7906ca63db

commit 5dfec2e14315abdaaa4a4a9fdedb3e7906ca63db
Author: Wai-Hong Tam <waihong@google.com>
Date: Mon Nov 14 23:00:35 2016

servod: Don't ask user to choose if only 1 servo-v4 + 1 servo-micro

It is a common scenario for a developer connecting one servo-v4 and
one servo-micro (or CCD endpoint). Don't ask user to choose and start
the servo v4. The servo-micro (or CCD) will be initialized in the
post_init phase.

BUG= chromium:665186 
TEST=Connected servo v4 and servo-micro (or CCD endpoint). Started
servod and verified no asking.

Change-Id: Ibab126a1b98bd594c19283cdf8d0e3b8bbe0e5e1
Reviewed-on: https://chromium-review.googlesource.com/411499
Commit-Ready: Wai-Hong Tam <waihong@google.com>
Tested-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/5dfec2e14315abdaaa4a4a9fdedb3e7906ca63db/servo/servod.py