Issue 665181 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ chenwilliam@chromium.org Last visit > 30 days ago
Closed:	Dec 2016
Components:	Platform>DevTools
EstimatedDays:	----
NextAction:	----
OS:	Linux
Pri:	2
Type:	Feature

DevTools: Typecheck with closure compiler on CQ

Project Member Reported by chenwilliam@chromium.org, Nov 14 2016

Issue description

Currently, devtools front-end only enforces closure compiler type checking as part of the presubmit hook. We should enforce this on the CQ as well to catch these static type issues even if a developer uses bypass hooks.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ee4d24c9f3a42d47950d78763fe8ff4f139395b

commit 2ee4d24c9f3a42d47950d78763fe8ff4f139395b
Author: chenwilliam <chenwilliam@chromium.org>
Date: Mon Nov 21 20:41:44 2016

DevTools: Add closure compile to buildbot to type check devtools front-end

This should only run when devtools front-end files are modified.

BUG= 665181 

Review-Url: https://codereview.chromium.org/2498123002
Cr-Commit-Position: refs/heads/master@{#433636}

[modify] https://crrev.com/2ee4d24c9f3a42d47950d78763fe8ff4f139395b/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/2ee4d24c9f3a42d47950d78763fe8ff4f139395b/testing/buildbot/gn_isolate_map.pyl
[add] https://crrev.com/2ee4d24c9f3a42d47950d78763fe8ff4f139395b/testing/scripts/run_devtools_closure_compile.py
[modify] https://crrev.com/2ee4d24c9f3a42d47950d78763fe8ff4f139395b/third_party/WebKit/Source/devtools/BUILD.gn

Comment 2 by chenwilliam@chromium.org, Dec 1 2016

Status: Fixed (was: Started)

►

Issue 665181 link

Issue metadata

DevTools: Typecheck with closure compiler on CQ

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 21 2016

Comment 1 Deleted

Comment 2 by chenwilliam@chromium.org, Dec 1 2016

Comment 2 Deleted

Sign in to add a comment