New issue
Advanced search Search tips

Issue 665169 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Don't parse JSON in browser

Project Member Reported by rouslan@chromium.org, Nov 14 2016

Issue description

Web payments module should parse JSON in renderer instead of browser.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571cfaafb1f82776520c02ae43d480343adb3bb8

commit 571cfaafb1f82776520c02ae43d480343adb3bb8
Author: rouslan <rouslan@chromium.org>
Date: Thu Nov 17 03:36:16 2016

Do not parse JSON in the browser.

Chrome is tightly integrated into Android Pay until it supports loose
integration into Android payment apps per  http://crbug.com/620173 . This
means that Chrome needs to parse JSON objects from the website and pass
them into Android Pay SDK. This parsing should happen in the renderer to
be safe.

BUG= 665169 

Review-Url: https://codereview.chromium.org/2500183002
Cr-Commit-Position: refs/heads/master@{#432725}

[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/components/payments/payment_request.mojom
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/third_party/WebKit/Source/modules/modules_idl_files.gni
[add] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/third_party/WebKit/Source/modules/payments/AndroidPayMethodData.idl
[add] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/third_party/WebKit/Source/modules/payments/AndroidPayTokenization.idl
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/571cfaafb1f82776520c02ae43d480343adb3bb8/third_party/WebKit/Source/modules/payments/PaymentRequest.h

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/230fb87fbc80bfc008df5f411a78734a3e259f3d

commit 230fb87fbc80bfc008df5f411a78734a3e259f3d
Author: Rouslan Solomakhin <rouslan@google.com>
Date: Thu Nov 17 03:42:34 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/230fb87fbc80bfc008df5f411a78734a3e259f3d

commit 230fb87fbc80bfc008df5f411a78734a3e259f3d
Author: Rouslan Solomakhin <rouslan@google.com>
Date: Thu Nov 17 03:42:34 2016

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment