I was just trying to build a demo for this and I noticed although the spec says that it should be available in the Worker Context, in the current impl it is not.
The demo app that I am building (qrsnapper.appspot.com) has all the detection logic in a worker thread and I would like to keep it there as much as possible.
Is there a plan to implement this on the worker?
Hi mcasas@, seems the latest commit (90149a4889e454cdca844de420d9deac61b99db6) prevent me from compiling chromium on my MacBook, the compiler says
../../services/shape_detection/barcode_detection_impl_mac.mm:69:8: error: 'CIQRCodeFeature' is only available on macOS 10_10 or newer [-Werror,-Wunguarded-availability]
for (CIQRCodeFeature* const f in features) {
^~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/Frameworks/CoreImage.framework/Headers/CIFeature.h:113:12: note: 'CIQRCodeFeature' has been explicitly marked partial here
@interface CIQRCodeFeature : CIFeature
^
../../services/shape_detection/barcode_detection_impl_mac.mm:69:8: note: enclose 'CIQRCodeFeature' in an @available check to silence this warning
for (CIQRCodeFeature* const f in features) {
^~~~~~~~~~~~~~~
1 error generated.
As you can see I am using 10.12 sdk and running MacOS 10.12.3, seems should not have this error. And can finish the compile before this CL landed. So please let me know if I missed something important, thanks!
ratsunny@: seems like you're compiling using the systems' XCode
and not the one checked out in build/mac_files/XCode.app, what's
your gn file contents (e.g. out/gn/args.gn)?
#19: First, try running the script build/mac_toolchain.py.
OTOH you should have run some command line like:
`gn gen out/gn`
or any other folder instead of out/gn, to then proceed with e.g.
`ninja -C out/gn chrome`
The gn command creates the file out/gn/args.gn and that's the
one I was asking about.
Note that [1] says "using Xcode is unsupported,", you should try
to compile using the XCode downloaded with Chromium.
[1] https://chromium.googlesource.com/chromium/src/+/master/docs/mac_build_instructions.md#Using-Xcode_Ninja-Hybrid
mcasas@: I believe I did all things mentioned in instructions. And previous build (12 hours ago) before this CL landed are all success.
And the error message I pasted in #17 is generated by ninja, not Xcode
▶ python build/mac_toolchain.py
Using local toolchain for mac.
▶ gn gen out/test
Done. Made 5668 targets from 1182 files in 3510ms
▶ ninja -C out/test chrome
ninja: Entering directory `out/test'
[53/28326] CC obj/native_client/src/trusted/desc/nrd_xfer/nacl_desc_cond.o^C
ninja: build stopped: interrupted by user.
▶ cat out/test/args.gn
cat: out/test/args.gn: No such file or directory
Since I'm not a googler, maybe we use different toolchain?
PS: I believe "using Xcode is unsupported," means use the built-in build function in Xcode is not supported, not the sdk shipped with Xcode.
Comment 1 by bugdroid1@chromium.org
, Nov 16 2016