CQ can completely halt when a too-large patch is attempted to be committed. |
||||||||
Issue descriptionI've received several reports on IRC that the CQ is wedged. The tree has been open for some time but we aren't seeing patches landing. https://codereview.chromium.org/2492343003/ is one example.
,
Nov 14 2016
Is this fallout and/or a bug caused by the webkit master restart?
,
Nov 14 2016
I'm looking into this now, I don't expect that this is related to the master restart though (but maybe)
,
Nov 14 2016
It looks like the CQ is busy trying to commit http://chromiumcodereview.appspot.com/2496663002, which I'm not actually able to get to successfully load at the moment..
,
Nov 14 2016
Ah, https://codereview.chromium.org/2496663002 loads for me. This patch is ginormous, which explains it.
,
Nov 14 2016
This change could be landed manually. Can we take it out of the CQ?
,
Nov 14 2016
I have taken the patch out of the CQ by unchecking the commit box.
,
Nov 14 2016
Yeah this should be landed manually I think.... It looks like there's a larger bug here though, which is that huge patches can take the CQ out of commission. Fortunately, I think this is a complete non-issue once chromium switches to gerrit. I think this is an artifact of the rietveld patching system. For CQ folks: it appears that CQ calls `git add` or `git rm` once for every file in the patch. This is apparently inefficient enough (?) that I suspect that it takes the CQ > cq_restart_cycle time to actually commit the patch. Thus the CQ spends all its time attempting to commit this, then it gets restarted, and the whole thing goes again.
,
Nov 16 2016
iannucci@ yeah, that sounds about right. Indeed, once I make Gerrit operation for Chromium, all the big patches should land just fine through it and with lower latency. In current Rietveld CQ, there isn't that much we can do without major re-architecturing which will take longer than getting Gerrit operation anyway.
,
Jan 23 2017
,
Jul 7 2017
Use gerrit for all patches :) |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pdr@chromium.org
, Nov 14 2016