New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665142 link

Starred by 2 users
Status: Fixed
Owner:
█ pschmidt@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
simonhatch@chromium.org
█ stip@chromium.org
█ robert...@chromium.org
█ nednguyen@chromium.org
eyaich@chromium.org
dtu@chromium.org
█ kerz@chromium.org
sullivan@chromium.org
█ benhenry@chromium.org
vhang@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove S5s from perf waterfalls

Project Member Reported by benhenry@google.com, Nov 14 2016 
Plan:

- We strip chromium.perf of all S5s. 
- We work to get a list of the devices that would make sense to have in our infrastructure that are representative of the world as we see it. 
- We keep the focus on getting chromium.perf's Android fleet onto swarming. Once clank-infra is freed up, they can start thinking about adding additional device types to their fleet, which we could benefit from.

This bug is about the first step.

Comment 1 by jbudorick@chromium.org, Nov 14 2016 

> - We work to get a list of the devices that would make sense to have in our infrastructure that are representative of the world as we see it.

If we're looking for devices that are representative, a Galaxy device of some kind would likely need to be included...

Comment 2 by sullivan@chromium.org, Nov 14 2016 

>> - We work to get a list of the devices that would make sense to have in our infrastructure that are representative of the world as we see it.

>If we're looking for devices that are representative, a Galaxy device of some kind would likely need to be included...

Yep, we just need to get the waterfall more stable before we put it back in. It's been down since August at least, see  bug 634052 .
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/80678bd9a45b0fbce3f3bb063649eda50c8bed98

commit 80678bd9a45b0fbce3f3bb063649eda50c8bed98
Author: Ben Henry <benhenry@google.com>
Date: Thu Nov 17 23:18:53 2016

Perf waterfalls: Remove S5s

BUG= 665142 
TEST=None

Change-Id: I4536e91b87febec429de38a09e6f260c6a02c57d
Reviewed-on: https://chromium-review.googlesource.com/411460
Commit-Queue: Ben Henry <benhenry@chromium.org>
Reviewed-by: David Tu <dtu@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/masters/master.chromium.perf.fyi/master.cfg
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/masters/master.chromium.perf.fyi/slaves.cfg
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/masters/master.chromium.perf/master.cfg
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/masters/master.chromium.perf/slaves.cfg
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipes/android/perf.py
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Builder_FYI.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/80678bd9a45b0fbce3f3bb063649eda50c8bed98

commit 80678bd9a45b0fbce3f3bb063649eda50c8bed98
Author: Ben Henry <benhenry@google.com>
Date: Thu Nov 17 23:18:53 2016

Perf waterfalls: Remove S5s

BUG= 665142 
TEST=None

Change-Id: I4536e91b87febec429de38a09e6f260c6a02c57d
Reviewed-on: https://chromium-review.googlesource.com/411460
Commit-Queue: Ben Henry <benhenry@chromium.org>
Reviewed-by: David Tu <dtu@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/masters/master.chromium.perf.fyi/master.cfg
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/masters/master.chromium.perf.fyi/slaves.cfg
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/masters/master.chromium.perf/master.cfg
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/masters/master.chromium.perf/slaves.cfg
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipes/android/perf.py
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/80678bd9a45b0fbce3f3bb063649eda50c8bed98/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Builder_FYI.json
[delete] https://crrev.com/6c22f32afe765d18c5325212b62d255b2e455a7c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/337448335a5f82ffbffdb5fb232a5175347a3935

commit 337448335a5f82ffbffdb5fb232a5175347a3935
Author: Ben Henry <benhenry@google.com>
Date: Fri Nov 18 23:01:31 2016
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/78ba335074b5cc536b11a1f5ff9883a7c63001f6

commit 78ba335074b5cc536b11a1f5ff9883a7c63001f6
Author: Ben Henry <benhenry@google.com>
Date: Fri Nov 18 23:03:01 2016

Comment 8 by benhenry@google.com, Nov 21 2016

Cc: benhenry@chromium.org vhang@chromium.org
Components: Infra>Labs
Owner: ----
Status: Untriaged (was: Assigned)
I'm handing this off to labs since the waterfalls no longer have S5s.

Comment 9 by pschm...@google.com, Nov 21 2016

Owner: pschmidt@chromium.org
Status: Assigned (was: Untriaged)
I can do this.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome-golo/chrome-golo.git/+/18570ba89a3ceaa84051533afa7c663f78581f9c

commit 18570ba89a3ceaa84051533afa7c663f78581f9c
Author: Peter Schmidt <pschmidt@google.com>
Date: Fri Jan 06 17:47:48 2017

Comment 11 by pschmidt@chromium.org, Jan 6 2017

Status: Fixed (was: Assigned)
These slaves and S5's have been reclaimed

Comment 12 by simonhatch@chromium.org, Jan 12 2017

Owner: simonhatch@chromium.org
Status: Available (was: Fixed)
https://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect

Think we need to take the bisect bots offline too

Comment 13 by benhenry@chromium.org, Jan 12 2017 

Do you want to do it, or me?

Comment 14 by simonhatch@chromium.org, Jan 13 2017

Owner: benhenry@chromium.org
I removed the bots from the dashboard, will hand off to you!

Comment 15 by benhenry@chromium.org, Jan 17 2017

Status: Assigned (was: Available)
So we need to remove them from the waterfall configs, then we can take them down?

Comment 16 by benhenry@google.com, Jan 19 2017

Labels: Pri-2

Comment 17 by pschm...@google.com, Jan 24 2017 

Yes, remove them from the waterfall configs, restart the master.  Then assign the ticket to me for final reclamation.

Comment 18 by benhenry@google.com, Feb 1 2017 

CL in flight. 

But there's also an S3 still attached to build43-b4 with ID: 3208582597be5193

Can we find that and remove it?

Comment 19 by pschm...@google.com, Feb 1 2017 

I can find it and remove it.  Can you give me a pointer to the cl?
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6b8bfa5d21e0f809050cbd19d41fa0e13cc58b92

commit 6b8bfa5d21e0f809050cbd19d41fa0e13cc58b92
Author: Ben Henry <benhenry@google.com>
Date: Wed Feb 01 23:05:42 2017

perf tryserver: Removing S5s from builder list

BUG= 665142 
TEST=None

Change-Id: I26369f5f6a8dc0f714111bb3f2c001ac3330e76d
Reviewed-on: https://chromium-review.googlesource.com/435568
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Henry <benhenry@chromium.org>

[modify] https://crrev.com/6b8bfa5d21e0f809050cbd19d41fa0e13cc58b92/masters/master.tryserver.chromium.perf/master.cfg
[modify] https://crrev.com/6b8bfa5d21e0f809050cbd19d41fa0e13cc58b92/masters/master.tryserver.chromium.perf/slaves.cfg
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json
[modify] https://crrev.com/6b8bfa5d21e0f809050cbd19d41fa0e13cc58b92/scripts/slave/recipes/bisection/android_bisect.py
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_no_changes_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_config_error_android_s5_perf_bisect.json
[delete] https://crrev.com/c17eb627e35ab562bb457da461fdfdd3bc19afd0/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json
[modify] https://crrev.com/6b8bfa5d21e0f809050cbd19d41fa0e13cc58b92/scripts/slave/recipes/bisection/android_bisect_staging.py

Comment 22 by benhenry@chromium.org, Feb 1 2017

Owner: pschmidt@chromium.org
Master restart in T-13minutes. Back to you, Peter.

Comment 23 by pschmidt@chromium.org, Feb 2 2017

Cc: nednguyen@chromium.org simonhatch@chromium.org eyaich@chromium.org robert...@chromium.org dtu@chromium.org
 Issue 665529  has been merged into this issue.

Comment 24 by pschmidt@chromium.org, Feb 2 2017

Status: Fixed (was: Assigned)
Hosts and devices have been reclaimed.
Project Member

Comment 25 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome-golo/chrome-golo/+/319192e2bc80ea780fdff6dec5d4861887e0aae2

commit 319192e2bc80ea780fdff6dec5d4861887e0aae2
Author: Peter Schmidt <pschmidt@google.com>
Date: Thu Feb 02 18:09:36 2017
►

Sign in to add a comment