New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665118 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[chromecast] cast_shell_tests fail

Project Member Reported by alokp@chromium.org, Nov 14 2016

Issue description

cast_shell_tests do not build or run on cast testbots. I have included them in the build and fixed build issues in this patch: https://codereview.chromium.org/2499563002/

However they currently fail.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e376792914583ebce6fa831a0d38100067d34bce

commit e376792914583ebce6fa831a0d38100067d34bce
Author: mbjorge <mbjorge@chromium.org>
Date: Tue Dec 13 23:53:06 2016

[Chromecast] Disable CastMediaBlocker intergration tests.

The CastMediaBlocker unittests are all DISABLED and the media blocker
browsertests are failing on devices. Once the unittests are all up and running,
perhaps some underlying issue will be sorted out that will help fix the
browsertests.

BUG=665118

Review-Url: https://codereview.chromium.org/2571583003
Cr-Commit-Position: refs/heads/master@{#438344}

[modify] https://crrev.com/e376792914583ebce6fa831a0d38100067d34bce/chromecast/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2738d5ab33c68b6249b64b06d650c71fd90af8b

commit b2738d5ab33c68b6249b64b06d650c71fd90af8b
Author: derekjchow <derekjchow@chromium.org>
Date: Thu Feb 02 18:32:29 2017

[Chromecast] Fix media session blocking tests.

This CL:
  1) Remove unneeded web_contents logic in CastMediaBlockerTest
  2) Makes MockMediaSession a pure mock
  3) Adds Add/RemoveObservers to MediaSession base class.
     This removes a bad static_cast from MockMediaSession to
     MediaSessionImpl.

BUG=665118
TEST=cast_shell_unittests

Review-Url: https://codereview.chromium.org/2623953002
Cr-Commit-Position: refs/heads/master@{#447801}

[modify] https://crrev.com/b2738d5ab33c68b6249b64b06d650c71fd90af8b/chromecast/browser/cast_media_blocker_unittest.cc
[modify] https://crrev.com/b2738d5ab33c68b6249b64b06d650c71fd90af8b/content/browser/media/session/media_session_impl.h
[modify] https://crrev.com/b2738d5ab33c68b6249b64b06d650c71fd90af8b/content/public/browser/media_session.h
[modify] https://crrev.com/b2738d5ab33c68b6249b64b06d650c71fd90af8b/content/public/browser/media_session_observer.cc
[modify] https://crrev.com/b2738d5ab33c68b6249b64b06d650c71fd90af8b/content/public/browser/media_session_observer.h

Sign in to add a comment