New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665105 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

clean up "testjob" option in cbuildbot

Project Member Reported by nxia@chromium.org, Nov 14 2016

Issue description

buildbucket_lib chooses the buildbucket server based on the prod flag, not on the testjob flag. 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a6e86e65d8e0e52ffacf5937f82665ef06a45262

commit a6e86e65d8e0e52ffacf5937f82665ef06a45262
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Nov 15 00:46:02 2016

Builds should choose the buildbucket server based on the CIDB type.

Clean up the testjob flag in the buildbucket_lib. Running builds should
pick the buildbucket-test sever when they're running on the debug CIDB and
the buildbucket server when they're running on the prod CIDB.

BUG= chromium:665105 
TEST=unit_tests

Change-Id: I723368801fb38de1c75c8bf6bf479573820e1fc2
Reviewed-on: https://chromium-review.googlesource.com/411364
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/remote_try.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/manifest_version_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/topology.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/completion_stages.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/manifest_version.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/sync_stages.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/buildbucket_lib.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/buildbucket_lib_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/lkgm_manager.py

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a6e86e65d8e0e52ffacf5937f82665ef06a45262

commit a6e86e65d8e0e52ffacf5937f82665ef06a45262
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Nov 15 00:46:02 2016

Builds should choose the buildbucket server based on the CIDB type.

Clean up the testjob flag in the buildbucket_lib. Running builds should
pick the buildbucket-test sever when they're running on the debug CIDB and
the buildbucket server when they're running on the prod CIDB.

BUG= chromium:665105 
TEST=unit_tests

Change-Id: I723368801fb38de1c75c8bf6bf479573820e1fc2
Reviewed-on: https://chromium-review.googlesource.com/411364
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/remote_try.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/manifest_version_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/topology.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/completion_stages.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/manifest_version.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/sync_stages.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/buildbucket_lib.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/buildbucket_lib_unittest.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/a6e86e65d8e0e52ffacf5937f82665ef06a45262/cbuildbot/lkgm_manager.py

Comment 3 by nxia@chromium.org, Nov 28 2016

Status: Fixed (was: Untriaged)

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment