Refactor download feedback uploading file handling and add reliability tests |
|||
Issue descriptionIn issue 655799, for cases where user clicks KEEP on downloads that are eligible for download feedback reporting, we create a temp copy of the download file and upload this temp copy to download feedback server instead of the actual download file. In this way, download files will be (almost) immediately available to user once they clicks KEEP. As a follow-up of issue 655799, if this mechanism works out fine, we are going to refactor download feedback service code to use the similar method for discarded download too. Meanwhile, add more tests to verify the reliability of this upload mechanism. For example, we want to test that download file (at GetFullPath()) can be safely deleted without the upload process getting interrupted.
,
May 5 2017
Some relevant code pointers: c/b/safe_browsing/download_feedback_service.cc void BeginFeedbackForDownload(..) //content/browser/download/download_item_impl.cc void StealDangerousDownload(..)
,
Nov 10 2017
,
Feb 8 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jialiul@chromium.org
, Nov 15 2016