New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665100 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 655799


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Refactor download feedback uploading file handling and add reliability tests

Project Member Reported by jialiul@chromium.org, Nov 14 2016

Issue description

In issue 655799, for cases where user clicks KEEP on downloads that are eligible for download feedback reporting, we create a temp copy of the download file and upload this temp copy to download feedback server instead of the actual download file. In this way, download files will be (almost) immediately available to user once they clicks KEEP.

As a follow-up of issue 655799, if this mechanism works out fine, we are going to refactor download feedback service code to use the similar method for discarded download too. 
Meanwhile, add more tests to verify the reliability of this upload mechanism. For example, we want to test that download file (at GetFullPath()) can be safely deleted without the upload process getting interrupted. 
 
Labels: SafeBrowsing-Triaged
Some relevant code pointers:
c/b/safe_browsing/download_feedback_service.cc  void BeginFeedbackForDownload(..)

//content/browser/download/download_item_impl.cc  void StealDangerousDownload(..)


Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Status: WontFix (was: Assigned)

Sign in to add a comment