New issue
Advanced search Search tips

Issue 665096 link

Starred by 2 users
Status: Fixed
Owner:
pkotw...@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Crash when tapping on notification created by tests.peter.sh

Project Member Reported by pkotw...@chromium.org, Nov 14 2016 
Crash when tapping on notification created by tests.peter.sh

Repro steps:
1) On an Android N device, enable WebAPKs by following the steps in https://docs.google.com/document/d/1NhK3-Q0HPV_8kSr_6IcjPPkxYjzzROhQPIOam7FK4mM/edit
2) Create a WebAPK for tests.peter.sh/notification-generator/ by selecting "Add to Home screen" in the app menu. An infobar will show temporarily then hide. Tap install when Android asks to install the "Notifications" application
3) Launch the newly created WebAPK
4) Grant tests.peter.sh permission to send notifications (An infobar should show up asking for permission)
5) Select "Cat photo (JPEG, 3072x1728) from the "Image" combo box.
6) Select "Only try to focus" from the "Action" combo box.
7) Tap the "Display the notification" button. This should display a notification
8) Tap the body of the notification.

Expected:
Notification disappears. WebAPK does not crash
Actual:
Notification disappears. WebAPK crashes
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e299953842a5913ea92cfeb6f0079acfb22ea407

commit e299953842a5913ea92cfeb6f0079acfb22ea407
Author: pkotwicz <pkotwicz@chromium.org>
Date: Wed Nov 16 01:53:40 2016

Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK.

The problem is with TabContentManager::CacheTab(). If
TabContentManager::CacheTab() is called while a readback for the tab is
pending, ThumbnailCache::Remove() is called.

ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG= 665096 

Review-Url: https://codereview.chromium.org/2497383002
Cr-Commit-Position: refs/heads/master@{#432352}

[modify] https://crrev.com/e299953842a5913ea92cfeb6f0079acfb22ea407/chrome/browser/android/compositor/tab_content_manager.cc

Comment 2 by pkotw...@chromium.org, Nov 16 2016

Status: Fixed (was: Started)
►

Sign in to add a comment