New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665087 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Hang in pdf_fm2js_fuzzer

Project Member Reported by ClusterFuzz, Nov 14 2016

Issue description

Comment 1 by ajha@chromium.org, Nov 22 2016

Labels: M-55
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 Deleted

Cc: thestig@chromium.org infe...@chromium.org mmoroz@chromium.org weili@chromium.org
Could someone please take a look?.
Thank you.
Status: Available (was: Untriaged)
Project Member

Comment 7 by ClusterFuzz, Mar 18 2017

Labels: OS-Mac
Project Member

Comment 9 by ClusterFuzz, Mar 27 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 6531870100815872 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: ClusterFuzz-Wrong
Status: Available (was: Verified)

Comment 11 by npm@chromium.org, Apr 10 2017

Cc: -npm@chromium.org
Owner: npm@chromium.org
Status: Started (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/5c97fd86374a1638710870a8603438f6d6fa11d1

commit 5c97fd86374a1638710870a8603438f6d6fa11d1
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Apr 11 15:27:16 2017

Avoid long assignment chain in FM parser

We only parse FM right before translating to JS. Our current implementation of
assignment will duplicate to first expression's ToJavascript. So having a long
chain of assignments will result in a huge ToJavascript.

Bug:  chromium:665087 
Change-Id: I542371b5787113be2f2d686153ed0a6c48191bab
Reviewed-on: https://pdfium-review.googlesource.com/4030
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/5c97fd86374a1638710870a8603438f6d6fa11d1/xfa/fxfa/fm2js/xfa_error.h
[modify] https://crrev.com/5c97fd86374a1638710870a8603438f6d6fa11d1/xfa/fxfa/fm2js/xfa_fmparse.cpp
[modify] https://crrev.com/5c97fd86374a1638710870a8603438f6d6fa11d1/xfa/fxfa/fm2js/xfa_error.cpp

Comment 13 by npm@chromium.org, Apr 12 2017

Status: Fixed (was: Started)
Project Member

Comment 15 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/715c833d5ba12cedbf0250778ce9c7db4a517490

commit 715c833d5ba12cedbf0250778ce9c7db4a517490
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Thu May 11 09:11:23 2017

Roll src/third_party/pdfium/ 21f88ffe5..4da1e7623 (7 commits)

https://pdfium.googlesource.com/pdfium.git/+log/21f88ffe5c2c..4da1e7623c52

$ git log 21f88ffe5..4da1e7623 --date=short --no-merges --format='%ad %ae %s'
2017-05-10 thestig Limit XFA FormCalc program translation size.
2017-05-09 thestig Split DCT decoder creation from CPDF_DIBSource::CreateDecoder().
2017-05-10 thestig Replace operator bool with HasRef() in classes with a CFX_SharedCopyOnWrite member.
2017-05-10 thestig Check CXFA_FM2JSContext::Translate() return value.
2017-05-10 dsinclair Store the offset in the archive buffer
2017-05-10 dsinclair Cleaning up Edit code
2017-05-10 npm Cleanup CGifDecompressor part 2

Created with:
  roll-dep src/third_party/pdfium
BUG= 665087 , 718492 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I72ea21ff11451a57fa0cdc532b5eceae31a682bb
Reviewed-on: https://chromium-review.googlesource.com/502630
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#470884}
[modify] https://crrev.com/715c833d5ba12cedbf0250778ce9c7db4a517490/DEPS

Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.

Sign in to add a comment