New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 665071 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Don't use UI message pump for DXVA video accelerator

Project Member Reported by stanisc@chromium.org, Nov 14 2016

Issue description

Now that the main GPU thread doesn't run UI message pump there is no reason for DXVA video accelerator to run one. Could it be switched to MessagePumpDefault.

That could help avoid crashes like this one:
https://bugs.chromium.org/p/chromium/issues/detail?id=664963


 
Components: Internals>GPU>Video
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8693fe6e737326df9b10f5cf961862af72c93187

commit 8693fe6e737326df9b10f5cf961862af72c93187
Author: jbauman <jbauman@chromium.org>
Date: Tue Nov 15 02:12:32 2016

Initialize DXVA decoder thread with MTA COM apartment model

This allows the thread to be created with a MessagePumpDefault and not
a UI message pump, which can improve performance and might decrease the
frequency of hangs.

MediaFoundation is the only COM used on this thread, and MTA is actually
the preferred apartment model for it.

BUG= 665071 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2504473002
Cr-Commit-Position: refs/heads/master@{#432059}

[modify] https://crrev.com/8693fe6e737326df9b10f5cf961862af72c93187/media/gpu/dxva_video_decode_accelerator_win.cc

Owner: jbau...@chromium.org
Status: Fixed (was: Untriaged)
Should this be merged to M55?

Sign in to add a comment