New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665062 link

Starred by 6 users
Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
█ pea...@gmail.com
robliao@chromium.org
gab@chromium.org
fdoray@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 665060
issue 675631



Sign in to add a comment

Rename TaskRunner::RunsTasksOnCurrentThread()

Project Member Reported by gab@chromium.org, Nov 14 2016 
As discussed @ https://groups.google.com/a/chromium.org/d/msg/chromium-dev/mXarHTy5Drg/oSuiABZwDAAJ

It is more and more important as things move to sequences and pools that this method's name be addressed (I just found myself writing unintuitive code because of this).

I suggest we:
 1) Define TaskRunner::RunsTasksInCurrentSequence()
 2) Make TaskRunner::RunsTasksOnCurrentThread() non-virtual and define it in task_runner.cc in terms of TaskRunner::RunsTasksInCurrentSequence().

(2) will force us to fix the overrides to be in terms of RunsTasksInCurrentSequence() and as such make sure every impl is already doing the right thing.

(2) will allow us to do this without having to also rename callers and having important changes lost in the rename noise.

 3) Mass rename for callers.

@fdoray for triage : this would be a good bug to start ramping someone new on our team :), potentially followed by more exciting migration work in base/ towards making APIs sequence-safe :).

Comment 1 by cmorehun...@gmail.com, Nov 24 2016 

U

Comment 2 by fdoray@chromium.org, Dec 19 2016

Cc: robliao@chromium.org gab@chromium.org fdoray@chromium.org
 Issue 646905  has been merged into this issue.

Comment 3 by fdoray@chromium.org, Dec 19 2016 

This is needed to avoid writing unintuitive code when making base APIs sequence-safe.

E.g.:

net/url_request/url_fetcher_core.h/.cc

scoped_refptr<base::SingleThreadTaskRunner> delegate_task_runner_;
becomes
scoped_refptr<base::SequencedTaskRunner> delegate_task_runner_;

DCHECK(delegate_task_runner_->BelongsToCurrentThread());
becomes
DCHECK(delegate_task_runner_->RunsTasksOnCurrentSequence());
(instead of RunsTasksOnCurrentThread())

Comment 4 by gab@chromium.org, Dec 19 2016

Blocking: 675631

Comment 5 by robliao@chromium.org, Mar 29 2017

Owner: ----
Status: Available (was: Untriaged)
Clearing owner as this might be a good ramp up bug.

Comment 6 by gab@chromium.org, Apr 18 2017

Cc: pea...@gmail.com
Status: Started (was: Available)
fdoray@ and I discussed this further offline (with work kicking off in https://codereview.chromium.org/2823103003/ :)), this call served two purposes:

1) Documenting calls' sequence association + providing run-time thread-safety logic.

2) Documenting method's context (e.g. "runs on blocking pool, not main thread").

For anything running on a SingleThread/SequencedTaskRunner: (1) and (2) are the same.

For parallel tasks however, (1) doesn't make sense so as we replace this API I think we should make it a TODO of this bug to try to move the API to SequencedTaskRunner::RunsTasksInCurrentSequence().

For parallel tasks it only makes sense to statically assert context (i.e. use case #2).

As such I propose we, as part of resolving this issue:
 1) Introduce static methods like TaskScheduler::AssertRunningInPool() and TaskSchedulerAssertRunningInPoolWithTraits()
 2) Make parallel TaskRunners (i.e. SchedulerParallelTaskRunner and
SequencedWorkerPool::Inner) return false for RunsTasksInCurrentSequence() and land it.
 3) Move RunsTasksInCurrentSequence() to SequencedTaskRunner().

Redirecting callers to the static methods in (1) to resolve failures in (2) and (3).

PS: We are currently migrating all tasks to TaskScheduler so should any of the above be blocked on an old TaskRunner's implementation's behaviour, the calling code should generally be migrated to TaskScheduler instead of bothering to fix the deprecated impl.
Project Member

Comment 7 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3322df623f6198576a688561fe22a8786b2e1e1f

commit 3322df623f6198576a688561fe22a8786b2e1e1f
Author: peary2 <peary2@gmail.com>
Date: Tue May 09 03:55:48 2017

Introduce TaskRunner::RunsTasksInCurrentSequence() to replace
TaskRunner::RunsTasksOnCurrentThread().

Make TaskRunner::RunsTasksOnCurrentThread() non-virtual and define
it in terms of TaskRunner::RunsTasksInCurrentSequence().

It's the first step to rename RunsTasksOnCurrentThread()
to RunsTasksInCurrentSequence().

BUG= 665062 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2823103003
Cr-Commit-Position: refs/heads/master@{#470173}

[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/deferred_sequenced_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/deferred_sequenced_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/message_loop/message_loop_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/message_loop/message_loop_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/task_scheduler/scheduler_worker_pool_impl.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/test/null_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/test/null_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/test/scoped_task_scheduler.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/test/test_mock_time_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/test/test_mock_time_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/test/test_simple_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/test/test_simple_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/threading/sequenced_worker_pool.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/threading/sequenced_worker_pool.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/threading/worker_pool.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/cc/test/ordered_simple_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/cc/test/ordered_simple_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/cc/tiles/image_controller_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chrome/browser/after_startup_task_utils.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chrome/browser/after_startup_task_utils.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chrome/browser/after_startup_task_utils_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chrome/browser/chromeos/login/users/mock_user_manager.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chrome/browser/memory/tab_manager_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chromecast/base/system_time_change_notifier_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chromeos/dbus/blocking_method_caller_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/chromeos/tpm/tpm_token_info_getter_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/components/memory_pressure/memory_pressure_monitor_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/components/user_manager/fake_user_manager.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/browser/browser_thread_impl.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/browser/dom_storage/dom_storage_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/browser/dom_storage/dom_storage_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/browser/startup_task_runner_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/child/blob_storage/blob_transport_controller_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/child/worker_thread_registry.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/renderer/categorized_worker_pool.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/renderer/categorized_worker_pool.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/ios/web/web_thread_impl.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/media/base/fake_single_thread_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/media/base/fake_single_thread_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/media/cast/test/skewed_single_thread_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/media/cast/test/skewed_single_thread_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/net/quic/chromium/test_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/net/quic/chromium/test_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/remoting/base/auto_thread_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/remoting/base/auto_thread_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/remoting/client/plugin/pepper_main_thread_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/remoting/client/plugin/pepper_main_thread_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/WebTaskRunner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate_for_test.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate_for_test.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_for_test.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_for_test.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/Source/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/third_party/WebKit/public/platform/scheduler/child/single_thread_idle_task_runner.h
[modify] https://crrev.com/3322df623f6198576a688561fe22a8786b2e1e1f/ui/accelerated_widget_mac/window_resize_helper_mac.cc
Project Member

Comment 8 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/229d9745b7d438ac230baa3f5c21945868e48256

commit 229d9745b7d438ac230baa3f5c21945868e48256
Author: peary2 <peary2@gmail.com>
Date: Fri May 12 01:55:19 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //content

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //content

BUG= 665062 

Review-Url: https://codereview.chromium.org/2873333004
Cr-Commit-Position: refs/heads/master@{#471176}

[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/browser_thread_impl.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/byte_stream.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/dom_storage/dom_storage_task_runner.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/fileapi/browser_file_system_helper.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/indexed_db/indexed_db_active_blob_registry.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/indexed_db/indexed_db_browsertest.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/indexed_db/indexed_db_internals_ui.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/indexed_db/indexed_db_quota_client.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/net/quota_policy_cookie_store_unittest.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/notifications/platform_notification_context_impl.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/plugin_private_storage_helper.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/renderer_host/pepper/quota_reservation.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/browser/tracing/memory_tracing_browsertest.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/child/child_message_filter.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/child/fileapi/webfilesystem_impl.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/child/fileapi/webfilewriter_impl.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/child/web_database_observer_impl.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/public/test/test_browser_thread.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/renderer/media/media_stream_audio_source.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/renderer/media/webrtc/webrtc_audio_sink.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/229d9745b7d438ac230baa3f5c21945868e48256/content/renderer/service_worker/worker_fetch_context_impl.cc
Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc

commit be58808056df4a76ea7ae3b6831bb8f24e2ad7fc
Author: peary2 <peary2@gmail.com>
Date: Wed May 17 01:59:49 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //chrome

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //chrome

BUG= 665062 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2871303004
Cr-Commit-Position: refs/heads/master@{#472283}

[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/after_startup_task_utils.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/browsing_data/browsing_data_file_system_helper.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/browsing_data/browsing_data_media_license_helper.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/browsing_data/media_licenses_counter.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/chromeos/app_mode/kiosk_app_data_base.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/chromeos/app_mode/kiosk_app_icon_loader.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/chromeos/policy/cloud_external_data_store.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/chromeos/power/freezer_cgroup_process_manager.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/chromeos/system/input_device_settings_impl_x11.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/download/download_commands.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/extensions/app_data_migrator.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/image_decoder.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/media_galleries/fileapi/native_media_file_util.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/policy/cloud/test_request_interceptor.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/printing/print_job.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/printing/print_job_unittest.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/printing/print_job_worker.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/printing/print_job_worker_owner.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/printing/print_job_worker_owner.h
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/printing/printer_query.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/safe_browsing/safe_browsing_database.h
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/safe_browsing/safe_browsing_store_file.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/drive_backend/callback_helper.h
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/drive_backend/sync_task_token.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/local/local_file_change_tracker.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/local/local_file_sync_context.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/sync_file_system/local/root_delete_helper.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/win/chrome_select_file_dialog_factory.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/browser/win/settings_app_monitor.cc
[modify] https://crrev.com/be58808056df4a76ea7ae3b6831bb8f24e2ad7fc/chrome/renderer/media/cast_rtp_stream.cc
Project Member

Comment 10 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3808747e5108af5ddb3825af7ae5a23b20fe1356

commit 3808747e5108af5ddb3825af7ae5a23b20fe1356
Author: peary2 <peary2@gmail.com>
Date: Thu May 18 03:40:40 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //android_webview, //tools

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //android_webview, //tools

BUG= 665062 

Review-Url: https://codereview.chromium.org/2881383003
Cr-Commit-Position: refs/heads/master@{#472641}

[modify] https://crrev.com/3808747e5108af5ddb3825af7ae5a23b20fe1356/android_webview/browser/cookie_manager.cc
[modify] https://crrev.com/3808747e5108af5ddb3825af7ae5a23b20fe1356/android_webview/browser/net/aw_cookie_store_wrapper.cc
[modify] https://crrev.com/3808747e5108af5ddb3825af7ae5a23b20fe1356/tools/android/forwarder2/device_controller.cc
[modify] https://crrev.com/3808747e5108af5ddb3825af7ae5a23b20fe1356/tools/android/forwarder2/device_listener.cc
[modify] https://crrev.com/3808747e5108af5ddb3825af7ae5a23b20fe1356/tools/android/forwarder2/forwarders_manager.cc
[modify] https://crrev.com/3808747e5108af5ddb3825af7ae5a23b20fe1356/tools/android/forwarder2/host_controller.cc
[modify] https://crrev.com/3808747e5108af5ddb3825af7ae5a23b20fe1356/tools/android/forwarder2/host_controllers_manager.cc
[modify] https://crrev.com/3808747e5108af5ddb3825af7ae5a23b20fe1356/tools/android/forwarder2/self_deleter_helper.h
Project Member

Comment 12 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bd3d49f9c5aa28cc95c175604883b57142f6ada

commit 0bd3d49f9c5aa28cc95c175604883b57142f6ada
Author: peary2 <peary2@gmail.com>
Date: Fri May 19 10:09:41 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //device, //services

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //device, /services

BUG= 665062 

Review-Url: https://codereview.chromium.org/2891853003
Cr-Commit-Position: refs/heads/master@{#473146}

[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/bluetooth/bluetooth_remote_gatt_characteristic_win.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/bluetooth/bluetooth_remote_gatt_descriptor_win.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/bluetooth/bluetooth_remote_gatt_service_win.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/bluetooth/bluetooth_socket_net.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/bluetooth/bluetooth_socket_win.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/bluetooth/bluetooth_task_manager_win.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/bluetooth/bluez/bluetooth_socket_bluez.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/power_save_blocker/power_save_blocker_android.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/power_save_blocker/power_save_blocker_chromeos.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/power_save_blocker/power_save_blocker_win.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/power_save_blocker/power_save_blocker_x11.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/serial/serial_io_handler.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/usb/usb_device_handle_impl.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/device/wake_lock/wake_lock_service_impl.cc
[modify] https://crrev.com/0bd3d49f9c5aa28cc95c175604883b57142f6ada/services/device/time_zone_monitor/time_zone_monitor_linux.cc
Project Member

Comment 13 by bugdroid1@chromium.org, May 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44f776856864c18d20350b3e4c24844edcff26db

commit 44f776856864c18d20350b3e4c24844edcff26db
Author: peary2 <peary2@gmail.com>
Date: Sat May 20 01:09:46 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //storage

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //storage

BUG= 665062 

Review-Url: https://codereview.chromium.org/2890143004
Cr-Commit-Position: refs/heads/master@{#473399}

[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/blob/blob_data_handle.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/database/database_quota_client.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/file_system_context.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/file_system_context.h
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/file_system_usage_cache.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/file_system_usage_cache.h
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/plugin_private_file_system_backend.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/quota/quota_backend_impl.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/sandbox_quota_observer.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/task_runner_bound_observer_list.h
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/fileapi/timed_task_helper.cc
[modify] https://crrev.com/44f776856864c18d20350b3e4c24844edcff26db/storage/browser/quota/quota_manager_proxy.cc
Project Member

Comment 14 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61491c6487631e3a949dbcdb55e8309f4d18998d

commit 61491c6487631e3a949dbcdb55e8309f4d18998d
Author: peary2 <peary2@gmail.com>
Date: Tue May 23 03:39:19 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //extensions, //headless, //mojo

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //extensions, //headless, //mojo

Additionally, used TaskScheduler instead of blocking pool
in storage_info_provider.cc referenced to  crbug.com/667892 .
The blocking pool is being deprecated in favor of TaskScheduler.

BUG= 665062 

Review-Url: https://codereview.chromium.org/2888053002
Cr-Commit-Position: refs/heads/master@{#473802}

[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/extensions/browser/api/networking_private/networking_private_linux.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/extensions/browser/api/system_storage/storage_info_provider.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/extensions/browser/sandboxed_unpacker.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/headless/public/util/generic_url_request_job.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/mojo/edk/system/channel_posix.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/mojo/edk/system/channel_win.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/mojo/edk/system/node_channel.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/mojo/edk/system/node_controller.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/mojo/public/cpp/bindings/thread_safe_interface_ptr.h
[modify] https://crrev.com/61491c6487631e3a949dbcdb55e8309f4d18998d/mojo/public/cpp/system/simple_watcher.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeac7780cf8392c00b9179fd09aed830fe9fbe22

commit aeac7780cf8392c00b9179fd09aed830fe9fbe22
Author: peary2 <peary2@gmail.com>
Date: Thu Jun 01 04:11:16 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //net

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG= 665062 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2894863002
Cr-Commit-Position: refs/heads/master@{#476185}

[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/base/directory_lister.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/base/directory_lister.h
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/cert/cert_database_mac.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/cert_net/cert_net_fetcher_impl.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/disk_cache/blockfile/backend_impl.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/disk_cache/blockfile/in_flight_backend_io.h
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/disk_cache/blockfile/in_flight_io.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/extras/sqlite/sqlite_channel_id_store.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/extras/sqlite/sqlite_persistent_cookie_store.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/http/http_server_properties_manager.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/http/http_server_properties_manager.h
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/http/http_server_properties_manager_unittest.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/http/transport_security_persister.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/log/file_net_log_observer.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/nqe/network_qualities_prefs_manager.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/nqe/network_qualities_prefs_manager.h
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/nqe/network_qualities_prefs_manager_unittest.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/proxy/proxy_config_service_android.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/ssl/channel_id_service.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/url_request/test_url_request_interceptor.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/url_request/url_fetcher_core.cc
[modify] https://crrev.com/aeac7780cf8392c00b9179fd09aed830fe9fbe22/net/url_request/url_fetcher_impl_unittest.cc

Comment 16 by gab@chromium.org, Jun 20 2017 

Thanks for taking this on peary2, how's this coming along? Cheers!

Comment 17 by pea...@gmail.com, Jun 21 2017 

Currently, I am working on this :)
codereview.chromium.org/2943923002
and
codereview.chromium.org/2889683003
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac76448402d65a2f5dc9ccea07916f009960e0b0

commit ac76448402d65a2f5dc9ccea07916f009960e0b0
Author: peary2 <peary2@gmail.com>
Date: Sun Jun 25 14:39:53 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //components

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //components

BUG= 665062 

Review-Url: https://codereview.chromium.org/2889683003
Cr-Commit-Position: refs/heads/master@{#482173}

[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/certificate_transparency/ct_policy_manager.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/component_updater/default_component_installer.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/device_event_log/device_event_log_impl.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/domain_reliability/monitor.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/drive/chromeos/file_cache.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/drive/chromeos/resource_metadata.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/gcm_driver/fake_gcm_client.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/gcm_driver/gcm_driver_desktop.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/history/core/browser/top_sites_impl.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/keyed_service/core/refcounted_keyed_service.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/metrics/leak_detector/leak_detector.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/policy/core/browser/url_blacklist_manager.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/policy/core/common/async_policy_loader.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/policy/core/common/cloud/external_policy_data_fetcher.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/policy/core/common/cloud/external_policy_data_updater.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/policy/core/common/cloud/policy_header_io_helper.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/policy/core/common/cloud/resource_cache.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/policy/core/common/policy_loader_ios.mm
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/safe_browsing_db/v4_database.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/safe_browsing_db/v4_store.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/sessions/core/base_session_service.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/sync/driver/shared_change_processor.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/sync/engine/fake_sync_manager.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/timers/alarm_timer_chromeos.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/update_client/background_downloader_win.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/update_client/component.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/update_client/crx_downloader.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/update_client/url_request_post_interceptor.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/user_manager/user_manager_base.cc
[modify] https://crrev.com/ac76448402d65a2f5dc9ccea07916f009960e0b0/components/wallpaper/wallpaper_resizer.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6c0d723f3422a148c8fd8b6291936654d68d690

commit b6c0d723f3422a148c8fd8b6291936654d68d690
Author: peary2 <peary2@gmail.com>
Date: Mon Jun 26 01:49:38 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //third_party

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //third_party

BUG= 665062 

Review-Url: https://codereview.chromium.org/2959613002
Cr-Commit-Position: refs/heads/master@{#482181}

[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/core/loader/SubresourceFilter.cpp
[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/platform/Timer.cpp
[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/platform/WebTaskRunner.h
[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp
[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl.cc
[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/b6c0d723f3422a148c8fd8b6291936654d68d690/third_party/WebKit/Source/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7c6056c1956d589069a5c20f960e4c66d7f5f88

commit a7c6056c1956d589069a5c20f960e4c66d7f5f88
Author: Yeol <peary2@gmail.com>
Date: Fri Jul 21 14:43:41 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //service

Renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //service

Bug:  665062 
Change-Id: Id5de459e44ff12c2f8d0ac64270c135ee902912e
Reviewed-on: https://chromium-review.googlesource.com/579317
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488653}
[modify] https://crrev.com/a7c6056c1956d589069a5c20f960e4c66d7f5f88/services/resource_coordinator/tracing/coordinator.cc
[modify] https://crrev.com/a7c6056c1956d589069a5c20f960e4c66d7f5f88/services/resource_coordinator/tracing/recorder.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0349534f91d9a1fc165c45a635b85d57450a4037

commit 0349534f91d9a1fc165c45a635b85d57450a4037
Author: Yeol <peary2@gmail.com>
Date: Fri Jul 21 16:03:50 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //chrome, //content

Renamed TaskRunner::RunsTasksOnCurrentThread() to

TaskRunner: :RunsTasksInCurrentSequence() in //chrome, //content
Bug:  665062 
Change-Id: I2d6a309bb5f116e521da91a7f66b4fe8b756a386
Reviewed-on: https://chromium-review.googlesource.com/558326
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488670}
[modify] https://crrev.com/0349534f91d9a1fc165c45a635b85d57450a4037/chrome/browser/win/taskbar_icon_finder.cc
[modify] https://crrev.com/0349534f91d9a1fc165c45a635b85d57450a4037/content/browser/browser_thread_unittest.cc
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28e1489e61fc2a4620bbdd84ba7cb34fdf9c9f52

commit 28e1489e61fc2a4620bbdd84ba7cb34fdf9c9f52
Author: Yeol <peary2@gmail.com>
Date: Mon Jul 24 14:09:40 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //media, //net

Renamed TaskRunner::RunsTasksOnCurrentThread() to

TaskRunner: :RunsTasksInCurrentSequence() in //media, //net
Bug:  665062 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib9c41a55fcc85695e9a2396ba7563e1efcd73050
Reviewed-on: https://chromium-review.googlesource.com/563149
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488963}
[modify] https://crrev.com/28e1489e61fc2a4620bbdd84ba7cb34fdf9c9f52/media/gpu/avda_surface_bundle.cc
[modify] https://crrev.com/28e1489e61fc2a4620bbdd84ba7cb34fdf9c9f52/net/test/embedded_test_server/simple_connection_listener.cc
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a89b266bed601b1526e49553ad929681c31b2de9

commit a89b266bed601b1526e49553ad929681c31b2de9
Author: Yeol <peary2@gmail.com>
Date: Tue Jul 25 17:09:10 2017

Rename TaskRunner::RunsTasksOnCurrentThread() in //base

Renamed TaskRunner::RunsTasksOnCurrentThread() to

TaskRunner: :RunsTasksInCurrentSequence() in //base
Bug:  665062 
Change-Id: I185b0b0948b5a821af233f60830d5c89743673f8
Reviewed-on: https://chromium-review.googlesource.com/563225
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489347}
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/debug/activity_tracker.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/files/file_path_watcher_fsevents.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/files/file_path_watcher_kqueue.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/files/file_path_watcher_linux.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/files/file_path_watcher_win.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/memory/ref_counted_delete_on_sequence.h
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/observer_list_threadsafe.h
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/observer_list_unittest.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/single_thread_task_runner.h
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/task/cancelable_task_tracker.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/task_runner.h
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/task_scheduler/task_scheduler_impl_unittest.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/task_scheduler/test_task_factory.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/task_scheduler/test_task_factory.h
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/test/scoped_mock_time_message_loop_task_runner.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/test/task_runner_test_template.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/test/task_runner_test_template.h
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/test/test_mock_time_task_runner.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/test/test_mock_time_task_runner.h
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/threading/sequenced_task_runner_handle.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/threading/sequenced_worker_pool.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/threading/sequenced_worker_pool_unittest.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/timer/timer_unittest.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/trace_event/memory_dump_scheduler_unittest.cc
[modify] https://crrev.com/a89b266bed601b1526e49553ad929681c31b2de9/base/win/object_watcher.cc

Comment 27 by gab@chromium.org, Jul 26 2017

Status: Fixed (was: Started)
Thanks peary2 for getting through this large undertaking :)!
►

Sign in to add a comment