New issue
Advanced search Search tips

Issue 665055 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Data race in blink::DOMException::create

Project Member Reported by ClusterFuzz, Nov 14 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5757056658440192

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 4
Crash Address: 0x7b0c000477f0
Crash State:
  blink::DOMException::create
  blink::WebIDBDatabaseCallbacksImpl::onAbort
  base::internal::Invoker<base::internal::BindState<void
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=431847:431858

Minimized Testcase (0.36 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96sIbRMjPirLsZglyacw90g-88cWvL8ETrskSXTbyKmcyWzsD9Z-QfY5cHqLnfEROxSGAA_UNeUZJ7i1e6JacAhV3ydHqpzVlNJwd3jFQvnP1oFQ5wRFQdXJJX00Iq5oKAz8iV7jSNdMZnySC0meEeUhJkrYA?testcase_id=5757056658440192

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>Storage
Owner: reillyg@chromium.org
Status: Assigned (was: Untriaged)
reillyg @ could you please look into this.please feel free to re-assigned back if needed. thanks in advance
Status: Started (was: Assigned)
Look like we need to be sure not to create the WebIDBDatabaseError on the IO thread.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3aa3a7b9ad75d9475df4340b5ed86c3d6240f3fa

commit 3aa3a7b9ad75d9475df4340b5ed86c3d6240f3fa
Author: reillyg <reillyg@chromium.org>
Date: Tue Nov 15 00:31:14 2016

Fix data race in IndexedDBDatabaseCallbacksImpl::Abort

It is not safe to pass a WebIDBDatabaseError between threads because it
contains non-threadsafe WebStrings. This change passes the components
necessary to construct the error object across threads and creates it
there.

BUG= 665055 

Review-Url: https://codereview.chromium.org/2506443002
Cr-Commit-Position: refs/heads/master@{#432019}

[modify] https://crrev.com/3aa3a7b9ad75d9475df4340b5ed86c3d6240f3fa/content/child/indexed_db/indexed_db_database_callbacks_impl.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment