New issue
Advanced search Search tips

Issue 665054 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security

Blocking:
issue 668814



Sign in to add a comment

Heap-buffer-overflow in TetrahedralInterpFloat

Project Member Reported by ClusterFuzz, Nov 14 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4686966764601344

Fuzzer: libfuzzer_pdf_codec_icc_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x60c0000007b0
Crash State:
  TetrahedralInterpFloat
  EvaluateCLUTfloat
  _LUTevalFloat
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=420535:420584

Minimized Testcase (0.29 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96VOrzoZkgpZxiMxG0I68uqDGheo5EvK-iCfRTy4M5qrQQyycTkK8fw_ud5LI6ttm6-Z26vzeL4qqakTVxle2ni9xkkN4TJt9m7OEz1z5ocsjEVbQRYZ7gSK8-PtrytJ8vXO74CyuK-Hb7psUVBaThgtXeEKg?testcase_id=4686966764601344

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by rickyz@chromium.org, Nov 14 2016

Components: Internals>Plugins>PDF
Owner: kcwu@chromium.org
Status: Assigned (was: Untriaged)
Hi, the change in  issue 657282  does not appear to have fixed the underlying issue here - mind taking a look?

Comment 2 by kcwu@chromium.org, Nov 15 2016

I will report this issue to upstream.

Project Member

Comment 3 by sheriffbot@chromium.org, Nov 15 2016

Labels: M-55
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 15 2016

Labels: ReleaseBlock-Stable
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 15 2016

Labels: Pri-1
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 16 2016

Labels: M-55

Comment 7 by gov...@chromium.org, Nov 18 2016

Cc: awhalley@chromium.org
A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Also due to Thanksgiving holidays in US, please make sure fix is ready and merged to M55 latest by 5:00 PM PT Wednesday, 11/23/16 (sooner the better).

Comment 8 by awhalley@google.com, Nov 18 2016

Labels: -M-55 -ReleaseBlock-Stable M-56
Out of time for M55 unfortunately. I'm OK not blocking the release on this - moving to M56.

Comment 9 by aarya@google.com, Nov 23 2016

 Issue 668149  has been merged into this issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 29 2016

kcwu: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by kcwu@chromium.org, Nov 30 2016

FYI, two weeks ago, I have reported this issue to upstream and got response that they plan to handle this issue in next release.

Project Member

Comment 12 by sheriffbot@chromium.org, Dec 9 2016

Labels: ReleaseBlock-Stable
Blocking: 668814
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 14 2016

kcwu: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3495d05a73e8c5d4227bf0a053b415f190b0354e

commit 3495d05a73e8c5d4227bf0a053b415f190b0354e
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Sat Dec 17 05:36:25 2016

Roll src/third_party/pdfium/ d5b81ce57..da587fab5 (1 commit).

https://pdfium.googlesource.com/pdfium.git/+log/d5b81ce57223..da587fab5760

$ git log d5b81ce57..da587fab5 --date=short --no-merges --format='%ad %ae %s'
2016-12-16 kcwu lcms: Sanitize floating point read

BUG= 665054 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2585983002
Cr-Commit-Position: refs/heads/master@{#439327}

[modify] https://crrev.com/3495d05a73e8c5d4227bf0a053b415f190b0354e/DEPS

Project Member

Comment 17 by ClusterFuzz, Dec 17 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5976201475915776 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 18 by sheriffbot@chromium.org, Dec 17 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 19 by ClusterFuzz, Dec 18 2016

ClusterFuzz has detected this issue as fixed in range 439312:439335.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4686966764601344

Fuzzer: libfuzzer_pdf_codec_icc_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x60c0000007b0
Crash State:
  TetrahedralInterpFloat
  EvaluateCLUTfloat
  _LUTevalFloat
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=420535:420584
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=439312:439335

Minimized Testcase (0.29 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96VOrzoZkgpZxiMxG0I68uqDGheo5EvK-iCfRTy4M5qrQQyycTkK8fw_ud5LI6ttm6-Z26vzeL4qqakTVxle2ni9xkkN4TJt9m7OEz1z5ocsjEVbQRYZ7gSK8-PtrytJ8vXO74CyuK-Hb7psUVBaThgtXeEKg?testcase_id=4686966764601344

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: Merge-Request-56
Project Member

Comment 21 by sheriffbot@chromium.org, Jan 13 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-56 Merge-Approved-56
Approved for merge into M56
Labels: -ReleaseBlock-Stable
Labels: -Hotlist-Merge-Review -M-56 -Security_Impact-Beta -Merge-Approved-56 M-57 Security_Impact-Stable
Cc: dsinclair@chromium.org
 Issue 696106  has been merged into this issue.
Labels: Release-0-57
Labels: -Release-0-57 Release-0-M57
Project Member

Comment 28 by ClusterFuzz, Mar 16 2017

Labels: OS-Mac
Project Member

Comment 29 by sheriffbot@chromium.org, Mar 26 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 30 by ClusterFuzz, Jul 14 2017

Labels: Needs-Feedback
ClusterFuzz testcase 5776305430986752 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.

Comment 31 by npm@chromium.org, Jul 14 2017

Labels: ClusterFuzz-Wrong
Uh testcase 5776305430986752 is not even the one corresponding to this bug?
Labels: -ClusterFuzz-Wrong
ClusterFuzz was not wrong, previously that testcase was attached to the duped  bug 696106 . Now i created a new bug - https://bugs.chromium.org/p/chromium/issues/detail?id=743162

Sign in to add a comment