New issue
Advanced search Search tips

Issue 665018 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Delete unused method

Reported by dyaros...@yandex-team.ru, Nov 14 2016

Issue description

Cc: rbasuvula@chromium.org
Labels: TE-NeedsTriageHelp
This looks like out of scope for TE, hence adding the respective label for it to  triage further.
Labels: -TE-NeedsTriageHelp M-56
Not in TE's scope.
Cc: pkasting@chromium.org
pkasting@ can you help triage this? It appears you had added the original code that is now dead.
Labels: Hotlist-GoodFirstBug OS-All
Status: Available (was: Unconfirmed)
This is unreferenced, and longstanding, so should be safe to remove.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62ef852f1de25d4ba2d877342791fb860479effd

commit 62ef852f1de25d4ba2d877342791fb860479effd
Author: ratsunny <ratsunny@gmail.com>
Date: Sun Dec 04 05:45:23 2016

Remove obsolete keywords table migrating function

Since the function KeywordTable::MigrateKeywordsTableForVersion45
is not used in codebase, it's safe to remove it.

R=pkasting@chromium.org
BUG= 665018 

Review-Url: https://codereview.chromium.org/2542933002
Cr-Commit-Position: refs/heads/master@{#436188}

[modify] https://crrev.com/62ef852f1de25d4ba2d877342791fb860479effd/components/search_engines/keyword_table.cc
[modify] https://crrev.com/62ef852f1de25d4ba2d877342791fb860479effd/components/search_engines/keyword_table.h

Status: Fixed (was: Available)

Sign in to add a comment