Delete unused method
Reported by
dyaros...@yandex-team.ru,
Nov 14 2016
|
|||||
Issue descriptionSeems like an unused old migration method: https://cs.chromium.org/chromium/src/components/search_engines/keyword_table.h?sq=package:chromium&rcl=1479111352&l=170 It should probably be deleted.
,
Nov 22 2016
Not in TE's scope.
,
Dec 1 2016
pkasting@ can you help triage this? It appears you had added the original code that is now dead.
,
Dec 1 2016
This is unreferenced, and longstanding, so should be safe to remove.
,
Dec 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62ef852f1de25d4ba2d877342791fb860479effd commit 62ef852f1de25d4ba2d877342791fb860479effd Author: ratsunny <ratsunny@gmail.com> Date: Sun Dec 04 05:45:23 2016 Remove obsolete keywords table migrating function Since the function KeywordTable::MigrateKeywordsTableForVersion45 is not used in codebase, it's safe to remove it. R=pkasting@chromium.org BUG= 665018 Review-Url: https://codereview.chromium.org/2542933002 Cr-Commit-Position: refs/heads/master@{#436188} [modify] https://crrev.com/62ef852f1de25d4ba2d877342791fb860479effd/components/search_engines/keyword_table.cc [modify] https://crrev.com/62ef852f1de25d4ba2d877342791fb860479effd/components/search_engines/keyword_table.h
,
Dec 6 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rbasuvula@chromium.org
, Nov 15 2016Labels: TE-NeedsTriageHelp