New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665006 link

Starred by 3 users
Status: Fixed
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

WebVr stuck at controller pair success screen

Project Member Reported by bshe@chromium.org, Nov 14 2016 
reproduce:
1. make sure that your default viewer is Daydream
2. click present button in a webvr page
3. on board your device to a daydream viewer
4. pair your controller

expected:
webvr content presented

what happened:
after a short black screen, it goes back to controller paired success screen. Even click home button won't go to daydream home.

Comment 1 by bshe@chromium.org, Nov 14 2016 

It looks like the reason is ChromeTabbedActivity is not exported so we can't directly launch the activity. Perhaps we can create an activity alias for CTA and export the alias.
Also, a quick test shows that WebVR is not auto present after controller paired and device onboard. We should fix it too.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d11fc27adf47033a732dc446f87ac55d29f53a

commit d7d11fc27adf47033a732dc446f87ac55d29f53a
Author: mthiesse <mthiesse@chromium.org>
Date: Thu Nov 17 03:39:08 2016

Fix broken VR transitions due to ChromeTabbedActivity not being exported.

Recently, VR transitions broke due to us properly registering as a VR capable app. For some reason this lead VrCore to handle us differently and try launching ChromeTabbedActivity, which it couldn't because it's not exported.

This CL updates our transition code to use the new daydream API calls, giving us enter and exit VR transitions. I also introduce an activity-alias for VR purposes so that VrCore can call back into us after the VR DON flow completes.

BUG= 665006 

Review-Url: https://codereview.chromium.org/2500153003
Cr-Commit-Position: refs/heads/master@{#432727}

[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/browser/android/vr_shell/vr_shell_delegate.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d11fc27adf47033a732dc446f87ac55d29f53a

commit d7d11fc27adf47033a732dc446f87ac55d29f53a
Author: mthiesse <mthiesse@chromium.org>
Date: Thu Nov 17 03:39:08 2016

Fix broken VR transitions due to ChromeTabbedActivity not being exported.

Recently, VR transitions broke due to us properly registering as a VR capable app. For some reason this lead VrCore to handle us differently and try launching ChromeTabbedActivity, which it couldn't because it's not exported.

This CL updates our transition code to use the new daydream API calls, giving us enter and exit VR transitions. I also introduce an activity-alias for VR purposes so that VrCore can call back into us after the VR DON flow completes.

BUG= 665006 

Review-Url: https://codereview.chromium.org/2500153003
Cr-Commit-Position: refs/heads/master@{#432727}

[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/d7d11fc27adf47033a732dc446f87ac55d29f53a/chrome/browser/android/vr_shell/vr_shell_delegate.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f97e23678abe358ec7c7241fe5511708be863625

commit f97e23678abe358ec7c7241fe5511708be863625
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Nov 18 03:30:58 2016

Clean up WebVR RequestPresent and make callback asynchronous.

BUG= 665006 

Review-Url: https://codereview.chromium.org/2510873003
Cr-Commit-Position: refs/heads/master@{#433063}

[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/test/fake_vr_device.h
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/vr_device.cc
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/vr_device.h
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/vr_display_impl.cc
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/device/vr/vr_display_impl.h
[modify] https://crrev.com/f97e23678abe358ec7c7241fe5511708be863625/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Comment 5 by mthiesse@chromium.org, Nov 18 2016

Status: Fixed (was: Assigned)

Comment 6 by mthiesse@chromium.org, Nov 29 2016

Labels: Merge-Request-56
Status: Started (was: Fixed)
Re-open for merge request. Thought this one had made it...

Comment 7 by dimu@chromium.org, Nov 29 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 29 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12d1a2f70164556c8fb55ef1a9bd8604aec15095

commit 12d1a2f70164556c8fb55ef1a9bd8604aec15095
Author: bshe <bshe@chromium.org>
Date: Tue Nov 29 20:09:21 2016

Clean up WebVR RequestPresent and make callback asynchronous.

BUG= 665006 

Review-Url: https://codereview.chromium.org/2510873003
Cr-Commit-Position: refs/heads/master@{#433063}
(cherry picked from commit f97e23678abe358ec7c7241fe5511708be863625)

Review URL: https://codereview.chromium.org/2536063003 .

Cr-Commit-Position: refs/branch-heads/2924@{#164}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/android/gvr/gvr_device_provider.cc
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/android/gvr/gvr_device_provider.h
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/test/fake_vr_device.h
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/vr_device.cc
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/vr_device.h
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/vr_display_impl.cc
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/device/vr/vr_display_impl.h
[modify] https://crrev.com/12d1a2f70164556c8fb55ef1a9bd8604aec15095/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Comment 9 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR-Daydream

Comment 10 by bshe@chromium.org, Dec 1 2016

Status: Fixed (was: Started)
►

Sign in to add a comment