New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 665000 link

Starred by 2 users
Status: Fixed
Owner:
█ rob.b...@samsung.com
Email to this user bounced
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 651762



Sign in to add a comment

menuitem.type should have restricted values

Reported by rob.b...@samsung.com, Nov 14 2016 
Right now we just reflect the type content attribute on menuitem.

However we should restrict the possible values:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

See:
https://html.spec.whatwg.org/#attr-menuitem-type
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c81588c798e7ca59e0e66b5439310c0587a2e6d

commit 1c81588c798e7ca59e0e66b5439310c0587a2e6d
Author: rob.buis <rob.buis@samsung.com>
Date: Tue Nov 15 01:43:37 2016

Restrict type attribute on menuitem

Restrict type attribute on menuitem to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG= 665000 

[1] https://html.spec.whatwg.org/#attr-menuitem-type

Review-Url: https://codereview.chromium.org/2372593005
Cr-Commit-Position: refs/heads/master@{#432046}

[modify] https://crrev.com/1c81588c798e7ca59e0e66b5439310c0587a2e6d/third_party/WebKit/LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt
[modify] https://crrev.com/1c81588c798e7ca59e0e66b5439310c0587a2e6d/third_party/WebKit/LayoutTests/fast/dom/domstring-attribute-reflection.html
[modify] https://crrev.com/1c81588c798e7ca59e0e66b5439310c0587a2e6d/third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-misc-expected.txt
[modify] https://crrev.com/1c81588c798e7ca59e0e66b5439310c0587a2e6d/third_party/WebKit/Source/core/html/HTMLMenuItemElement.idl

Comment 2 by rob.b...@samsung.com, Nov 15 2016

Status: Fixed (was: Assigned)
Fixed by r432046.
►

Sign in to add a comment