New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664990 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Buried. Ping if important.
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Issue implementing the CSP directive frame-src

Reported by davidf...@gmail.com, Nov 14 2016

Issue description

Chrome Version       : 54.0.2840.99 m
URLs (if applicable) : https://www.economical.com/en/careers/career-opportunities
Other browsers tested:
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari: OK
    Firefox: OK
         IE: OK

What steps will reproduce the problem?
(1) Visit https://www.economical.com/en/careers/career-opportunities
(2) Click Search Button in the iframe
(3) Click on any search result
(4) Click the Send to a Friend button in the bottom right corner
(5) Click the Send button

What is the expected result?
Clicking the Send button should open a new email in the users preferred client

What happens instead?
Nothing. The console says that the button click violates the CSP directive frame-src. However, this has been set to * so every src should be allowed


Please provide any additional information below. Attach a screenshot if
possible.
In version Version 53.0.2785.143 m - Works of Chrome this issue did not arise so this must have been something introduced recently
We have also implemented the child-src directive and set it to * but this does not work either
 
Screenshot.jpg
247 KB View Download
Components: Blink>HTML>Frame
Labels: -Type-Bug -Pri-3 M-56 OS-Windows Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows 10, mac 10.11.6 and Ubuntu 14.04 using chrome reported version #54.0.2840.99 and latest canary #56.0.2920.0.

Bisect Information:
=====================
Good build: 54.0.2840.15
Bad Build : 54.0.2840.16

Could not run the bisect tool as the good and bad builds are branch builds. Hence, providing the CL from omahaproxy.

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/54.0.2840.15..54.0.2840.16?pretty=fuller&n=10000

Unable to find any suspect from the above CL, could anyone from the dev team please look into this issue.

Thanks...!!

Comment 2 by tkent@chromium.org, Nov 18 2016

Components: -Blink>HTML>Frame Blink>SecurityFeature

Comment 3 by davidf...@gmail.com, Nov 22 2016

Any update on this issue?

Comment 4 by mkwst@chromium.org, Feb 23 2017

Owner: mkwst@chromium.org
Status: Started (was: Untriaged)
I see. We're treating `mailto:` as a navigation, and disallowing it because it doesn't match the policy (and isn't a standard scheme so it doesn't match `*`). For better or worse, even if you'd fixed the `frame-src` bit, it still wouldn't have worked, because we're also blocking it as mixed content. :(

Comment 5 by mkwst@chromium.org, Feb 24 2017

Labels: -Pri-1 -M-56 M-54 OS-Android OS-Chrome OS-Linux OS-Mac Pri-2
1. I overstated the mixed content impact; we treat it as passive mixed content. The request isn't blocked, but it degrades the security UX of the browser. In general, I think that's a good idea for non-webby schemes that launch native applications. That kind of communication is potentially dangerous, and marking it as such seems reasonable.

2. `mailto:` is specced as a navigation, and implemented as such in browsers. I'm torn as to whether we should special-case it as part of `*` in CSP. On the one hand, I think it was probably a mistake to limit `*` to webby schemes. On the other, `mailto:` is baked-into the platform in a way that other custom schemes aren't. So... I'll start a spec discussion.

Comment 6 by davidf...@gmail.com, Feb 24 2017

I fixed this issue on my side by adding mailto: to the default-src  

Comment 7 by mkwst@chromium.org, Feb 24 2017

I think that's a reasonable solution (and I apologize that it took me so long to see this). I also think that, at a minimum, we should improve Chrome's error message so that the scope of `*` is clear, because it isn't at all today. :(

Comment 8 by davidf...@gmail.com, Feb 24 2017

Sounds good to me

Comment 9 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment