New issue
Advanced search Search tips

Issue 664974 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

NameDictionary::kNotFound == current->property_dictionary()->FindEntry(name) in

Project Member Reported by ClusterFuzz, Nov 14 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5170464453558272

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_ignition_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  NameDictionary::kNotFound == current->property_dictionary()->FindEntry(name) in 
  
Regressed: V8: r40945:40946

Minimized Testcase (6.70 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94kDc4GT7eGUcfZOFGY8_5w1hYEgwv3EOmfGh74EDw7BwX6YoO726qx6yOOI3whmBHheVZFL34OHMIhqjeD6SAKO43tTn83ClbYiHnza7iJI9AHVRdVcjCxF6Pz_LdHerwN9CK9PiWhrFuh-25Fv2VwY7wd8Q?testcase_id=5170464453558272

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by danno@chromium.org, Nov 17 2016

Cc: jkummerow@chromium.org
Owner: ishell@chromium.org
Status: Assigned (was: Untriaged)
Labels: ReleaseBlock-Stable M-56
The fix for this will have to be merged into our 5.6 branch (assuming it's an observable issue).

Comment 3 by ishell@chromium.org, Nov 18 2016

Status: Started (was: Assigned)

Comment 5 by ishell@chromium.org, Nov 21 2016

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 7 by ClusterFuzz, Nov 22 2016

ClusterFuzz has detected this issue as fixed in range 41132:41133.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5170464453558272

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_ignition_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  NameDictionary::kNotFound == current->property_dictionary()->FindEntry(name) in 
  
Regressed: V8: r40945:40946
Fixed: V8: r41132:41133

Minimized Testcase (6.70 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94kDc4GT7eGUcfZOFGY8_5w1hYEgwv3EOmfGh74EDw7BwX6YoO726qx6yOOI3whmBHheVZFL34OHMIhqjeD6SAKO43tTn83ClbYiHnza7iJI9AHVRdVcjCxF6Pz_LdHerwN9CK9PiWhrFuh-25Fv2VwY7wd8Q?testcase_id=5170464453558272

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Any merge required in V8 branch? If not please remove Merge-TBD label.
Labels: -Merge-TBD Merge-Request-56
Merging is required. I'll merge it back once I get approval for  issue 665886 .

Comment 11 by dimu@chromium.org, Dec 2 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Thanks for the update in #10.

FYI: M56 Beta promotion is scheduled on Dec 6 & RC cut on Monday, Dec 5 @ 4.00 PM PST.Please ensure to verify the fix and merge your change ASAP so that we could take it for next Release.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 5 2016

Labels: merge-merged-5.6
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8feaaa256e6e36aad210467d808001bc26471e98

commit 8feaaa256e6e36aad210467d808001bc26471e98
Author: ishell@chromium.org <ishell@chromium.org>
Date: Mon Dec 05 12:47:56 2016

Merged: Squashed multiple commits.

Merged: [ic] Invalidate prototype validity cell when a slow prototype becomes fast.
Revision: f718cd1309be2327d1d218560f8663f8b165e4fa

Merged: [ic] Don't check full prototype chain if name is a private symbol.
Revision: 4513532f6362353eaf50ec30d753a346e795b164

BUG= chromium:664802 , chromium:664974 , chromium:665886 ,v8:5561
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=cbruni@chromium.org

Review URL: https://codereview.chromium.org/2554503002 .

Cr-Commit-Position: refs/branch-heads/5.6@{#32}
Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1}
Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014}

[modify] https://crrev.com/8feaaa256e6e36aad210467d808001bc26471e98/src/factory.cc
[modify] https://crrev.com/8feaaa256e6e36aad210467d808001bc26471e98/src/ic/ic.cc
[modify] https://crrev.com/8feaaa256e6e36aad210467d808001bc26471e98/src/objects.cc
[modify] https://crrev.com/8feaaa256e6e36aad210467d808001bc26471e98/src/objects.h
[modify] https://crrev.com/8feaaa256e6e36aad210467d808001bc26471e98/src/prototype.h
[add] https://crrev.com/8feaaa256e6e36aad210467d808001bc26471e98/test/mjsunit/regress/regress-crbug-664802.js
[add] https://crrev.com/8feaaa256e6e36aad210467d808001bc26471e98/test/mjsunit/regress/regress-crbug-664974.js
[add] https://crrev.com/8feaaa256e6e36aad210467d808001bc26471e98/test/mjsunit/regress/regress-crbug-665886.js

Labels: -Merge-Approved-56
Project Member

Comment 15 by sheriffbot@chromium.org, Dec 16 2016

Labels: Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 16 2016

This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by dimu@google.com, Dec 16 2016

Labels: -Merge-Review-56 -Hotlist-Merge-Review
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review

Sign in to add a comment