Issue metadata
Sign in to add a comment
|
Embedded Twitter videos don't play |
||||||||||||||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): M54, M56 canary iOS Version: 10.2 Device: 6S Steps to reproduce: 1. Go to http://www.huffingtonpost.com/entry/mary-j-blige-serenaded-hillary-clinton_us_57ea90d4e4b024a52d2ab053 2. Scroll down to the embedded Twitter video (after the text "But folks on Twitter thought otherwise after they saw a video of Mary J. Blige serenading Clinton with aforementioned cover when Apple Music shared it on Twitter on Monday.") Observed behavior: There is no video shown on the screen. Expected behavior: Video should show up. Works in Safari, picture attached. Frequency: 5/5 <number of times you were able to reproduce> Additional comments: This was mentioned in App Store reviews / TestFlight. This seems to be a regression - used to work previously.
,
Nov 14 2016
We should check WebView (test app available from app store). Does it work in M54 in current app store release?
,
Nov 14 2016
Broken in M54 App Store. Works in UIWebView/WKWebView/SafariVC from WebView test app.
,
Nov 14 2016
This can be related to SDK version we link. Mike could you please check if this is reproducible with stock WKWebView app build with iOS 10 SDK.
,
Nov 14 2016
This is a pretty serious regression. We shouldn't ship another version without fixing.
,
Nov 14 2016
It appears that this is related to an injected script and not the SDK it is built with. It works in ios_web_shell target OK.
,
Nov 15 2016
I believe this may be more related to the webpage rather than the scripts we are injecting. The video that doesn't appear is displayed in an iframe and there are errors emitted when the page is loaded about a sandbox violation. The error from our script can be found in |elementsFromCoordinates| in core.js at the final return statement. The error appears here when clicking on the missing video's iframe. A similar error is likely the cause of this video never loading in the first place.
,
Nov 15 2016
Even if web page does something wrong we still should understand what causes this bug from Chrome side. What if we remove all chrome scripts (like autofill, translate, etc)? Or maybe try generic user agent?
,
Nov 15 2016
I was unable to see a change after preventing the injection of all the scripts. However, thank you for reminding me to test user agent. Commenting out our customUserAgent FIXES the video and allows it to properly render.
,
Nov 15 2016
Mike, is this bug reproducible with test WKWebView and Chrome UA?
,
Nov 15 2016
Yes, I can cause the failure in WKWebView test app using Chrome's UA. eugenebut@, Do you think this means that this is a failure of the video player code to detect what type of playback is supported?
,
Nov 15 2016
It could be a workaround for video playback bug we had in M53 (caused by linking with iOS 9 SDK and fixed in M54). Mike, could you please attach your test WKWebView app to demonstrate the problem. We should let Twitter know about this bug.
,
Nov 15 2016
Claude, should we block M55 release on this? This is Twitter's bug (which we going to escalate in a separate thread), but their website works fine with M54.
,
Nov 15 2016
Just to clarify, this is broken currently in M54. (It could be twitter or huffingtonpost website causing the problem.)
,
Nov 15 2016
Thanks! Then there is no need to block M55 then.
,
Nov 16 2016
We let Twitter know about this bug.
,
Nov 16 2016
I agree eugene.
,
Nov 16 2016
I've attached a sample app which demonstrates this problem.
,
Nov 30 2016
,
Dec 13 2016
Seems to be fixed on stable from the Twitter side.
,
Dec 13 2016
,
Dec 13 2016
Verified fixed on 57.0.2942.0dev on Iphone7Plus iOS10.2 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by linds...@chromium.org
, Nov 14 2016