New issue
Advanced search Search tips

Issue 664943 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add support for MIR credit cards

Project Member Reported by se...@yandex-team.ru, Nov 14 2016

Issue description

In Russia we have a new payment system called "MIR" ("world" in English) with card numbers started with digits "22". Card number uses Luhn checksum and the length is always 16 digits. Possible icon for autofill is attached.
http://www.nspk.ru/en/cards-mir/

We want to add this new card type to Chromium. I wonder if it's OK to add a new card type to chrome, autofill, android/ios resources, etc? Will it just work or do we need something else to add? What about server-side autofill logic?

If there is no possible problems, I would like to open a CL with all required modifications and continue discussion there.
 
mir_200.png
1.4 KB View Download
Components: UI>Browser>Autofill

Comment 2 by zkoch@chromium.org, Nov 15 2016

Cc: ma...@chromium.org
This seems like a reasonable thing to support from my perspective. Mathp, can you comment on technical side?
Do you have more sizes for the icon? See all icon sizes for VISA, for example:

https://cs.chromium.org/search/?q=file:visa.png+-file:third_party&sq=package:chromium&type=cs
Yes, I have all icon sizes and I'll add them in CL. Attached image in the first message is an example of icon.

Comment 5 by ma...@chromium.org, Nov 16 2016

Hi sense@, this is very interesting indeed! Would love to support more payment types.

On a typical site, would it be in the same forms as other credit cards or separate forms (for which we could add triggering logic)?

Also do you have the bandwidth to add this to chromium yourself? 

Thanks!
Hi Mathp,

It must be in the same form as usual MasterCard/Visa. Fields are all the same: 4x4 (or 1x16) card number, valid until, cardholder name, CVC.

I think I can handle all this by myself but maybe I will have some questions about Android/iOS things.
I can provide support for adding this to PaymentRequest.

Comment 8 by ma...@chromium.org, Nov 16 2016

Cc: rouslan@chromium.org
Owner: se...@yandex-team.ru
Status: Assigned (was: Unconfirmed)
Status: Started (was: Assigned)
Labels: -Type-Bug Type-Feature
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33df534e7266b40a9759feacb86a7db02c62b655

commit 33df534e7266b40a9759feacb86a7db02c62b655
Author: sense <sense@yandex-team.ru>
Date: Tue Nov 29 21:59:44 2016

Add Mir credit card support to autofill.

BUG= 664943 

Review-Url: https://codereview.chromium.org/2514753002
Cr-Commit-Position: refs/heads/master@{#435085}

[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/build/android/lint/suppressions.xml
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-hdpi/mir_card.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-hdpi/pr_mir.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-mdpi/mir_card.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-mdpi/pr_mir.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-xhdpi/mir_card.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-xhdpi/pr_mir.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-xxhdpi/mir_card.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-xxhdpi/pr_mir.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-xxxhdpi/mir_card.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/res/drawable-xxxhdpi/pr_mir.png
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/browser/android/resource_id.h
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/autofill/core/browser/autofill_data_util.cc
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/autofill/core/browser/credit_card.h
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/autofill/core/browser/validation.cc
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/autofill_strings.grdp
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/resources/autofill_scaled_resources.grdp
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/resources/default_100_percent/autofill/mir.png
[add] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/components/resources/default_200_percent/autofill/mir.png
[modify] https://crrev.com/33df534e7266b40a9759feacb86a7db02c62b655/ios/chrome/browser/autofill/form_suggestion_label.mm

Status: Available (was: Started)
I need some help here. Autofill support was added, but sync server doesn't know anything about this card type.
What should we do with the state of the issue now? Maybe reassign to someone?

Comment 13 by ma...@chromium.org, Nov 30 2016

Status: Assigned (was: Available)
Hi sense,

Local cards don't sync, so this is working as intended so far. Does Chrome offer to save it locally when you submit a cc form?
Well, not Chrome but I tried to play with Chromium and it understands this card type properly.
Status: Fixed (was: Assigned)
This issue is fixed. Sync server downloads cards from https://payments.google.com, which is managed by a separate team with different priorities. Once people will able to add MIR cards to https://payments.google.com, the sync server will be updated accordingly. This bug is fixed now. Thank you for your contribution.

Sign in to add a comment