New issue
Advanced search Search tips

Issue 664942 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 663324



Sign in to add a comment

Difference between fullcode and ignition_staging_turbo: string vs. array access

Project Member Reported by machenb...@chromium.org, Nov 14 2016

Issue description

# Minimized program:
var v = 'x';
function foo() {
  return v[0];
}
foo();
%OptimizeFunctionOnNextCall(foo);
print(foo());


# Compared fullcode with ignition_turbo

# Flags of fullcode:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging  --random-seed 1273058210 --nocrankshaft --turbo-filter=~
# Flags of ignition_turbo:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging  --random-seed 1273058210 --ignition-staging --turbo

Difference:
- x
+ 120

### Start of configuration fullcode:
x

### End of configuration fullcode

### Start of configuration ignition_turbo:
120

### End of configuration ignition_turbo

 
Summary: Difference between fullcode and ignition_staging_turbo: string vs. array access (was: Difference between fullcode and ignition_staging_turbo_opt: string vs. array access)
No always opt.

Comment 2 by jarin@chromium.org, Nov 14 2016

Owner: bmeu...@chromium.org
Status: Assigned (was: Untriaged)
Components: Blink>JavaScript>Compiler
Labels: Arch-All OS-All
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/566728031025e7b8c171f91cb1e0537ebcb0813b

commit 566728031025e7b8c171f91cb1e0537ebcb0813b
Author: bmeurer <bmeurer@chromium.org>
Date: Mon Nov 14 11:57:54 2016

[turbofan] Properly allocate constant-folded string.

When constant-folding S[K], make sure to return a String, and not the
character code as Number.

BUG= chromium:664942 
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2503433002
Cr-Commit-Position: refs/heads/master@{#40960}

[modify] https://crrev.com/566728031025e7b8c171f91cb1e0537ebcb0813b/src/compiler/js-native-context-specialization.cc
[add] https://crrev.com/566728031025e7b8c171f91cb1e0537ebcb0813b/test/mjsunit/regress/regress-crbug-664942.js

Status: Fixed (was: Started)
Labels: v8-foozzie-failure

Sign in to add a comment