Difference between fullcode and ignition_staging_turbo: string vs. array access |
|||||
Issue description
# Minimized program:
var v = 'x';
function foo() {
return v[0];
}
foo();
%OptimizeFunctionOnNextCall(foo);
print(foo());
# Compared fullcode with ignition_turbo
# Flags of fullcode:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 1273058210 --nocrankshaft --turbo-filter=~
# Flags of ignition_turbo:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 1273058210 --ignition-staging --turbo
Difference:
- x
+ 120
### Start of configuration fullcode:
x
### End of configuration fullcode
### Start of configuration ignition_turbo:
120
### End of configuration ignition_turbo
,
Nov 14 2016
,
Nov 14 2016
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/566728031025e7b8c171f91cb1e0537ebcb0813b commit 566728031025e7b8c171f91cb1e0537ebcb0813b Author: bmeurer <bmeurer@chromium.org> Date: Mon Nov 14 11:57:54 2016 [turbofan] Properly allocate constant-folded string. When constant-folding S[K], make sure to return a String, and not the character code as Number. BUG= chromium:664942 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2503433002 Cr-Commit-Position: refs/heads/master@{#40960} [modify] https://crrev.com/566728031025e7b8c171f91cb1e0537ebcb0813b/src/compiler/js-native-context-specialization.cc [add] https://crrev.com/566728031025e7b8c171f91cb1e0537ebcb0813b/test/mjsunit/regress/regress-crbug-664942.js
,
Nov 14 2016
,
Dec 13 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by machenb...@chromium.org
, Nov 14 2016