New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664934 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

master-manager CL creation failed badly

Project Member Reported by tandrii@chromium.org, Nov 14 2016

Issue description

To cancel, edit desired_master_state.json in https://chrome-internal.googlesource.com/infradata/master-manager.

Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...

Presubmit checks passed.
 desired_master_state.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Adding self-LGTM (Code-Review +1) because of TBRs
remote: Processing changes: new: 1, done            
remote: 
remote: New Changes:        
remote:   https://chrome-internal-review.googlesource.com/304755 Restarting master chromium.fyi        
remote: 
To https://chrome-internal.googlesource.com/infradata/master-manager
 * [new branch]      d46b228b737baf8844e11841768e0e479af19773 -> refs/for/refs/heads/master%l=Code-Review+1,notify=NONE,r=ddoman@google.com,r=thakis@google.com
Traceback (most recent call last):
  File "/depot_tools/git_cl.py", line 5398, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/depot_tools/git_cl.py", line 5380, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/depot_tools/git_cl.py", line 4209, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/depot_tools/git_cl.py", line 1613, in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, change)
  File "/depot_tools/git_cl.py", line 2849, in CMDUploadChange
    self._GetGerritHost(), self.GetIssue(), cc, is_reviewer=False)
  File "/depot_tools/gerrit_util.py", line 636, in AddReviewers
    jmsg = ReadHttpJsonResponse(conn, ignore_404=False)
  File "/depot_tools/gerrit_util.py", line 356, in ReadHttpJsonResponse
    conn, expect_status=expect_status, ignore_404=ignore_404)
  File "/depot_tools/gerrit_util.py", line 349, in ReadHttpResponse
    raise GerritError(response.status, reason)
gerrit_util.GerritError: Unprocessable Entity: Change not visible to chrome-reviews@google.com

Traceback (most recent call last):
  File "/home/tandrii/.chrome-infra/infra/run.py", line 29, in <module>
    sys.exit(run_helper.run_py_main(sys.argv[1:], RUNPY_PATH, ENV_PATH, 'infra'))
  File "/home/tandrii/.chrome-infra/infra/bootstrap/run_helper.py", line 125, in run_py_main
    runpy.run_module(args[0], run_name='__main__', alter_sys=True)
  File "/usr/lib/python2.7/runpy.py", line 176, in run_module
    fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 82, in _run_module_code
    mod_name, mod_fname, mod_loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/tandrii/.chrome-infra/infra/infra/tools/restart/__main__.py", line 46, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/tandrii/.chrome-infra/infra/infra/tools/restart/__main__.py", line 42, in main
    args.desired_state, args.reason)
  File "/home/tandrii/.chrome-infra/infra/infra/tools/restart/restart.py", line 360, in run
    desired_state, reason)
  File "/home/tandrii/.chrome-infra/infra/infra/tools/restart/restart.py", line 278, in commit
    subprocess.check_call(upload_cmd, cwd=target)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'cl', 'upload', '-m', 'Restarting master chromium.fyi\n\nhttps://codereview.chromium.org/2492363002/\n\nBUG=664860\nTBR=ddoman@google.com, thakis@google.com', '-f', '-c']' returned non-zero exit status 1

What's worse, the issue wasn't set before this failure:

1:tandrii@andrii:/ii/infra argcomplete$ git cl web
ERROR No issue to open
 
Oh yes, and of course issue didn't make it to CQ either :(

Comment 2 by aga...@chromium.org, Nov 14 2016

Status: Started (was: Untriaged)
What the hell, I've already registered chrome-reviews@google.com on chrome-internal-review.googlesource.com. Other people have mentioned that it didn't seem to be registered, but this is the first automation failure due to that.

I'll try to figure out why it still thinks that isn't a legit address.

Comment 3 by aga...@chromium.org, Nov 14 2016

Cc: aga...@chromium.org
 Issue 664895  has been merged into this issue.

Comment 4 by aga...@chromium.org, Nov 14 2016

I just uploaded a CL and setting chrome-reviews@ as a CC worked just fine. Can tandrii@ or stip@ confirm that this is still broken for you?

Comment 7 by aga...@chromium.org, Nov 14 2016

Status: Fixed (was: Started)

Sign in to add a comment