New issue
Advanced search Search tips

Issue 664922 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Nov 2016
Cc:
tandrii@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Couldn't change gerrit commit message with depot_tools

Project Member Reported by machenb...@chromium.org, Nov 14 2016 
I uploaded https://chromium-review.googlesource.com/#/c/411100/ and forgot to specify TBR.

As usually with rietveld I used the command line in my local branch:
git commit --amend
> Specified TBR= in editor.
git cl upload
> A new patch was uploaded.

Expectation: I thought I'd see the changed commit message in gerrit.
Actual: New patchset but no change. Maybe I just misunderstood the new workflow. But a hint when trying to change the commit message locally would be nice.

Comment 1 by tandrii@chromium.org, Nov 14 2016

Status: WontFix (was: Untriaged)
The workflow with depot_tools is the same as before. You don't have to amend, but you should use git cl description after first uploaded to do what you want.

For, amend workflow is pure git workflow for Gerrit.

WAI for now, so won't fix, but feel free to reopen if I forgot smth.

Comment 2 by machenb...@chromium.org, Nov 14 2016 

Alright, that worked. Now I know this ;)
►

Sign in to add a comment