Committer-LGTM check with gerrit is later than with rietveld |
||||
Issue descriptionUploaded and tried to commit https://chromium-review.googlesource.com/#/c/411100/ Planned but forgot to specify TBR and just scheduled committing. Expectation: I expected the CQ to quickly tell me that I have no lgtm. Actual: The build presubmit trybot ran 4 times, and failed each time. The information about the missing lgtm could only be found in the stdout in one of the failing builds.
,
Nov 14 2016
That's true. I'll probably be fixed by issue 641422 according to current proposal there, but it's not set in stone yet, so I keep this issue open.
,
Nov 14 2016
I wonder why did presubmit run 4 times? Shouldn't we have 1 retry (2 tries) at most?
,
Nov 14 2016
We have more for build as it is so flaky. But that's orthogonal...
,
Nov 15 2016
,
Jan 12 2017
Duping this into the issue mentioned above, as we have decided to go with the plan there, so the CQ will be checking permissions quickly. |
||||
►
Sign in to add a comment |
||||
Comment 1 by machenb...@chromium.org
, Nov 14 2016