Sorry for the churn here, was going to update this bug to track avoiding deletion of the LevelDB files when deleting the Directory's sqllite files, but I decided to make a new bug instead. Didn't mean to change title when adding Sync-V2 label.

Hi,

Reading list will be released as part of M-57.
Does this bug need some action before that?

I wrote a CL to address this, although it fails to compile because of dependencies cycle. http://crrev.com/2663553003
I'll fix them on Monday.

Will moving store affect existing data?

Yes, it will. Synced data will be redownloaded from server. Local only data will be left in old location. New location will start with empty store.

How big impact this is going to have? Do we need to add code for data migration?

We released a beta, so I don't know if we need a migration.
+mardini to see if it is acceptable to clear the RL for beta users (and canary user).

If it is easier (and cleaner) to blow out the reading list for folks then I'm fine with it but need to send to chrome-ios-discuss@ and bling-team@ let dev and canary users know about this before it happens. I personally would be a bit pissed but if you're using dev/canary, you should expect these things to happen. 

We don't have any TestFlight users on Beta yet, right? When you say "clear the RL for beta users" I guess you mean dev ? The one on Dogfoody?

I think so, but we may want to block testflight until it is released if we want to avoid having issues.

TestFlight is still on M56.

So let's submit it and cherry-pick before testflight pass to M57.
I will send a mail explaining that items not synced will be lost.

Thanks

Adding RBB.

This is blocking M57 Beta now for our TestFlight users. The sooner we get this cherry-picked the better. Thanks. 

Olivier: You'll send an email to the two mailing lists mentioned in # 9 ?

Yes, I can send the mail.
WI will have to wait until pavely@ land it.
Or I may send it in advance. What is best?

Waiting till it lands is better so we're sure what we're telling users :). 

My change has landed: http://crrev.com/2663553003
Not sure why the bug wasn't updated.

This change allows reading list to share store with other sync types instead of creating separate object and files.

Requesting merge to M57.

I sent the email.

Please merge this as soon as possible so we can release a Beta build by the end of this week.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d8931e30890ee660e2f6cc777b9c71544f6ef6

commit 27d8931e30890ee660e2f6cc777b9c71544f6ef6
Author: Pavel Yatsuk <pavely@google.com>
Date: Wed Feb 01 21:41:51 2017

Get ModelTypeStoreFactory for reading list from ProfileSyncService

This CL switches ReadingListModelFactory to using ProfileSyncService's factory
for ModelTypeStore. This allows ReadingList to share store with other types.

R=olivierrobin@chromium.org
BUG= 664920 

Review-Url: https://codereview.chromium.org/2663553003
Cr-Commit-Position: refs/heads/master@{#447390}
(cherry picked from commit 9d905484261b3bf9205c65d95b86f306914a8581)

Review-Url: https://codereview.chromium.org/2667213002 .
Cr-Commit-Position: refs/branch-heads/2987@{#254}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/27d8931e30890ee660e2f6cc777b9c71544f6ef6/ios/chrome/browser/reading_list/BUILD.gn
[modify] https://crrev.com/27d8931e30890ee660e2f6cc777b9c71544f6ef6/ios/chrome/browser/reading_list/reading_list_model_factory.cc
[modify] https://crrev.com/27d8931e30890ee660e2f6cc777b9c71544f6ef6/ios/chrome/browser/sync/BUILD.gn
[modify] https://crrev.com/27d8931e30890ee660e2f6cc777b9c71544f6ef6/ios/chrome/browser/tabs/tab_model_order_controller_unittest.mm

Verified in 58.0.3005.0 canary, iPhone 6+ iOS 10.2, iPad mini 10.1
Tested that Reading list is synced between devices with the same account.
Looks good.

Also verify in M57 please.

Verified in 57.0.2987.35 dev, iPhone 6+ iOS 10.2, iPad mini 10.1
Tested that Reading list is synced between devices with the same account.
Looks good.

verified the issue on the latest beta build 57.0.2987.35 tested on iPhone 7+(iOS 10) and iPhone6(iOS 10).
Tested that Reading list is synced between devices with the same account.
Looks good.