New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664910 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 665214
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Double rippling effect is seen on extension icon within wrench.

Reported by dmascare...@etouch.net, Nov 14 2016

Issue description

Chrome Version:56.0.2918.0 (Official Build) 6015da67bcb535f343caf0f5cff5867d7f4487d8-refs/heads/master@{#431795}
OS: Windows(7,8,10)

Test url:
https://chrome.google.com/webstore/detail/skype/lifbcibllhkdhoafpjfnlhfpfgnpldfl?utm_source=chrome-app-launcher-info-dialog

What steps will reproduce the problem?
1. Launch chrome and navigate to above url,click on 'Add to chrome'
2. Drag the extension icon within wrench and right click on it
3. Observe the rippling effect of extension icon.

Actual:Double rippling effect is seen on extension icon
Expected: Single rippling effect should be seen on extension icon

This is regression issue, broken in 'M55' and below is manual bisect info:

Good build:55.0.2880.0
Bad build:55.0.2881.0

Note: Issue is not seen on Mac and Linux OS.
 
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Cc: rbasuvula@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2880.0 (Revision: 422654).
Bad build: 55.0.2881.0 (Revision: 423030).

You are probably looking for a change made after 422664 (known good), but no later than 422665 (first known bad).


CHANGE-LOG URL:
---------------------------------------
https://chromium.googlesource.com/chromium/src/+log/55e6683f5fad4e9ee67af77ffc2300cf4198c195..f02568a216b975130849079183cc0f7173d6b832



From the CL above, assigning the issue to the concern owner

@ estade : 
------------------
Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2382443007

Note :It is specific to windows.

Comment 3 by est...@chromium.org, Nov 15 2016

Cc: bruthig@chromium.org
Labels: -Pri-1 Pri-2
Owner: pkasting@chromium.org
I don't understand the problem description (specifically, what "within wrench" might mean).

+bruthig for ripples and assigning to pkasting for triage of apparently windows-only bug
If it's specific to windows it smells like it's caused by a different, 'unexpected', event stream compared to the other platforms.  However, it might just be more noticeable on windows...

This is loosely related to  issue 665214  and I think would be fixed if we removed the ripple effect completely.

To investigate you can add a break point or logs to InkDropRipple::AnimatetoState() to see what animations are actually being triggered.
Labels: Needs-Feedback
I just checked the rippling of this case yesterday and I didn't see any "double-ripple", just a single ripple (that looked overly rapid).  I suspect this is a pure dupe of  bug 665214 .

Please provide video of precisely what the problem you see on Windows is, as well as the comparative good behavior on CrOS or Linux (not Mac) at the same version.
Labels: -Needs-Feedback
Able to reproduce the issue on Windows 10 using latest canary #56.0.2920.0.
Unable to reproduce the issue in Ubuntu 14.04 using latest canary #56.0.2920.0.

Attaching the screen cast of both bad behavior(Windows-10) and good behavior(Linux).

pkasting@ - Please let us know if anything else is needed from our side.

664910_Win10.mp4
635 KB View Download
664910_Linux.ogv
1.2 MB View Download
Labels: Needs-Feedback
I'm sorry, but the Windows video has such heavy compression artifacts, with  I can't tell what it's supposed to be showing.  Please capture a small window at a high bitrate, and try to avoid any extraneous mouse movement, as it results in artifacts.

I don't see any ripple effect at all in the Linux video, just a hover rect that remains stable when clicked.  If what you're seeing in the Windows video is simply that there's a small, fast ripple on click, this is a dupe of  bug 665214 , and even better than posting a new video would be just closing it as such.
dmascarenhas@ Could you please respond for the comment #7.
Just to to update the latest behavior of the bug, Issue is still observed on windows 10 with chrome latest canaray M57-57.0.2938.0

pkasting@ Could you please let us know is there any recent update available on this issue?

Attaching a screen-cast for your reference.

Thanks!
Attaching the new screen-cast
Issue 664910-1.mp4
281 KB View Download
Mergedinto: 665214
Status: Duplicate (was: Assigned)
Thanks for the clearer imagery.  This is definitely the same issue.

Sign in to add a comment