New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664906 link

Starred by 2 users
Status: Fixed
Owner:
█ bruthig@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
jmukthavaram@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Tab focus is not seen on added extension icon in omnibox surface area.

Reported by rk...@etouch.net, Nov 14 2016 
Chrome Version: 56.0.2918.0 6015da67bcb535f343caf0f5cff5867d7f4487d8-refs/heads/master@{#431795} (64-bit) 
OS: Windows(7,8,10)

URL: https://chrome.google.com/webstore/detail/skype/lifbcibllhkdhoafpjfnlhfpfgnpldfl?utm_source=chrome-app-launcher-info-dialog

What steps will reproduce the problem?
(1) Launch chrome, navigate to above url and click on 'ADD TO CHROME' button.
(2) Press F6 key(focus appear in omnibox), then Press Tab key and observe.

Actual: Tab focus is not seen on added extension icon.

Expected: Tab focus should seen on added extension icon.

This is regression issue, broken in ‘M 56’ and will soon update other info :
Good build:56.0.2913.0 
Bad build: 56.0.2914.0
Actual_Focus.mp4
622 KB View Download
Expected_Focus.mp4
455 KB View Download

Comment 1 by jmukthavaram@chromium.org, Nov 14 2016

Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision
Owner: bruthig@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Tool Info:
---------------------

CHANGELOG URL:

The script might not always return single CL as suspectas some perf builds might
 get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/a4682914fc8311ff96c6b4f2a4ee890f36c56e97..ca8b19cd01cfb691bfa31e4605f4204dd8da8aab

Possible suspect:
https://chromium.googlesource.com/chromium/src/+/ca8b19cd01cfb691bfa31e4605f4204dd8da8aab

bruthig@ Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Thanks.!

Comment 2 by msrchandra@chromium.org, Nov 14 2016

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression.
Please remove if not required.
Thank You.

Comment 3 by bruthig@chromium.org, Nov 14 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b5f4f77a0227bc21cd8616b6e24c48c18484b3d

commit 3b5f4f77a0227bc21cd8616b6e24c48c18484b3d
Author: bruthig <bruthig@chromium.org>
Date: Tue Nov 15 04:46:40 2016

[top-chrome-md] Made extension buttons show the highlight when focused.

This is fixing a recent regression caused by
https://codereview.chromium.org/2447523002.

BUG= 664906 

Review-Url: https://codereview.chromium.org/2495213006
Cr-Commit-Position: refs/heads/master@{#432102}

[modify] https://crrev.com/3b5f4f77a0227bc21cd8616b6e24c48c18484b3d/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Comment 6 by bruthig@chromium.org, Nov 15 2016

Status: Fixed (was: Started)
►

Sign in to add a comment