New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664894 link

Starred by 1 user
Status: Fixed
Owner:
tapted@chromium.org
Closed: Nov 2016
Cc:
█ spqc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: Resting on the trackpad should reveal overlay scrollers.

Project Member Reported by tapted@chromium.org, Nov 14 2016 
Chrome Version       : 56.0.2914.3
OS Version: OS X 10.12.1

See  Issue 139553  and Issue 142364 about related behaviour for the content area.

What steps will reproduce the problem?
1. In MacViews ScrollView (e.g. Task Manager with chrome://flags/#mac-views-native-dialogs), with overlay scrollers (in System Preferences), rest two fingers on the trackpad

What is the expected result?

Scrollers should be revealed in the directions that indicate possible scrolling directions.


What happens instead of that?

No scrollers, until scrolling starts.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721

commit 83cbf3e99c4710133abde8c5a26e8c1ff4f0d721
Author: tapted <tapted@chromium.org>
Date: Wed Nov 16 08:04:01 2016

MacViews: Reveal scrollbars when resting on the trackpad.

ScrollViews on Mac should reveal overlay scrollers when just resting on
the trackpad, without movement. Currently they only appear once
scrolling has begun in a particular direction.

To fix, allow scrollbars to observe ui::ScrollEvents on their hosting
ScrollView, and behave appropriately.

Update the overlay scroll bars in an override of ScrollBar::Update(..)
rather than BaseScrollBar::ScrollToPosition(..). This is because changes
to scroll positions coming from a cc::InputHandler go through
ScrollView::OnLayerScrolled(), and not ScrollView::ScrollToOffset, so
they are not always seen by ScrollToPosition().

Update ui::test::EventGenerator to support these Rest/CancelRest events,
and map them to native NSEvents in event_generator_delegate_mac.mm. Also
map EventGenerator::ScrollSequence in a way that makes sense for the
event stream that AppKit provides.

BUG= 664894 

Review-Url: https://codereview.chromium.org/2454323002
Cr-Commit-Position: refs/heads/master@{#432417}

[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/events/event.cc
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/events/event.h
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/events/test/event_generator.cc
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/events/test/event_generator.h
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/controls/scroll_view.cc
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/controls/scroll_view_unittest.cc
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/controls/scrollbar/base_scroll_bar.cc
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/controls/scrollbar/base_scroll_bar.h
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/controls/scrollbar/cocoa_scroll_bar.h
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/controls/scrollbar/cocoa_scroll_bar.mm
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/controls/scrollbar/scroll_bar.cc
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/controls/scrollbar/scroll_bar.h
[modify] https://crrev.com/83cbf3e99c4710133abde8c5a26e8c1ff4f0d721/ui/views/test/event_generator_delegate_mac.mm

Comment 2 by tapted@chromium.org, Nov 17 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment