New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664887 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In chrome://system, incomplete line seperator is seen on clicking 'Expand' button.

Reported by lpa...@etouch.net, Nov 14 2016 
Version: 56.0.2918.0 (Official Build) dev (64-bit) Revision 6015da67bcb535f343caf0f5cff5867d7f4487d8-refs/heads/master@{#431795} (64-bit)
OS: Mac (10.11.6, 10.12.1)

What steps will reproduce the problem?
1) Launch chrome, go to chrome://system, in second column click on any 'Expand...' button.
2) Observe the line seperator between the two columns.

Incomplete line seperator is seen.

Line seperator should be seen throughout.

This is a Regression issue broken in M-56, will soon update other info

Comment 1 by lpa...@etouch.net, Nov 14 2016

Labels: hasbisect OS-Linux OS-Windows
Manual bisect:
Good build: 56.0.2917.0
Bad build: 56.0.2918.0 

Note: Issue is reproducible on Windows (7,8,10) and Linux (14.04 LTS).
system_actual.jpg
280 KB View Download

Comment 2 by msrchandra@chromium.org, Nov 14 2016

Components: Blink>Paint
Labels: -hasbisect hasbisect-per-revision
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2917.0 (Revision: 431726).
Bad build: 56.0.2918.0 (Revision: 431795).

You are probably looking for a change made after 431743 (known good), but no later than 431744 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/28625ccf0b3bcbcf118f06024f78d975f7575d5b..c5cc11e88930c6e3f5e08b330fb14b6b571a0404

@wangxianzhu -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2a470747585456b0c545551d61a7b3f7baffda9

commit b2a470747585456b0c545551d61a7b3f7baffda9
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon Nov 14 19:27:35 2016

Revert of Paint collapsed borders of a table as one display item (patchset #10 id:180001 of https://codereview.chromium.org/2430313004/ )

Reason for revert:
Caused  bug 664887 . We miss invalidation of collapsed borders when they are changed by layout.

BUG= 664887 

Original issue's description:
> Paint collapsed borders of a table as one display item
>
> This simplifies paint invalidation logic on collapsed border changes.
>
> About performance:
> With this CL we create a big display item on the table containing all
> collapsed border paintings, instead of many small display items on cells.
> This will cause more painting when the display item is invalidated, but
> saves time to handle many cached display items. Perf try jobs [1] show
> that this CL actually improves performance of one test
> (blink_perf.paint.large-table-background-change-with-invisible-collapsed-borders.html),
> and doesn't affect much of performance of other tests.
> Cluster-telemetry run showed no change or slight progression [2].
>
> [1] https://codereview.chromium.org/2430313004/#ps60001
> [2] https://ct.skia.org/chromium_perf_runs/, run 1433
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> BUG= 663208 
>
> Committed: https://crrev.com/c5cc11e88930c6e3f5e08b330fb14b6b571a0404
> Cr-Commit-Position: refs/heads/master@{#431744}

TBR=chrishtr@chromium.org,wkorman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 663208 

Review-Url: https://codereview.chromium.org/2495343002
Cr-Commit-Position: refs/heads/master@{#431903}

[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table-outer-border-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/border-collapse-change-separate-to-collapse-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-cell-append-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-color-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-width-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-color-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-width-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-color-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-width-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-row-border-width-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-color-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-width-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-tbody-border-width-expected.txt
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.html
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color.html
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.html
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color.html
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.html
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color.html
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/layout/LayoutTableSection.h
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/paint/TableCellPainter.h
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/paint/TablePainter.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/paint/TablePainter.h
[delete] https://crrev.com/f32a269ac0dbe6b08ddb73b1f77798db5dbf525a/third_party/WebKit/Source/core/paint/TablePainterTest.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/core/paint/TableSectionPainter.h
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/b2a470747585456b0c545551d61a7b3f7baffda9/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

Comment 4 by kkaluri@chromium.org, Nov 17 2016

Labels: TE-Verified-56.0.2922.0 TE-Verified-M56
Verified the fix on Windows 10, Ubuntu 14.04 and Mac 10.12.1 using Chrome Dev#56.0.2922.0 as per the comment #0.

Observed that the fix is working as expected.

Attaching the screencast for reference

Hence, adding the verified labels
Issue 664887.mp4
8.5 MB View Download

Comment 6 by wangxianzhu@chromium.org, Nov 28 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16363da3f8fba57bef3d203bbb8590bf4f60037e

commit 16363da3f8fba57bef3d203bbb8590bf4f60037e
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon Dec 05 22:26:58 2016

Paint collapsed borders of a table as one display item

This simplifies paint invalidation logic on collapsed border changes.

About performance:
With this CL we create a big display item on the table containing all
collapsed border paintings, instead of many small display items on cells.
This will cause more painting when the display item is invalidated, but
saves time to handle many cached display items. Perf try jobs [1] show
that this CL improves performance of one test
(blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
and degrade performance of one test
(blink_perf.paint.large-table-repaint.html)
and doesn't affect much of performance of other tests.
Cluster-telemetry run showed no change or slight progression (https://ct.skia.org/chromium_perf_runs/, run 1433)

This is a reland of https://codereview.chromium.org/2430313004, with
 crbug.com/664887  fixed by force invalidation of collapsed borders on
layout change.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
BUG= 663208 , 664887 
TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with changed display item types about collapsed borders)

Review-Url: https://codereview.chromium.org/2430313004
Review-Url: https://codereview.chromium.org/2502353003
Cr-Original-Commit-Position: refs/heads/master@{#431744}
Cr-Commit-Position: refs/heads/master@{#436426}

[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table-outer-border-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table-section-repaint-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/border-collapse-change-separate-to-collapse-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-cell-append-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-color-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-width-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-color-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-width-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-color-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-width-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-row-border-width-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-color-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-width-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-tbody-border-width-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize-expected.txt
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.html
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.txt
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color.html
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.html
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.txt
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color.html
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.html
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.txt
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color.html
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/layout/LayoutTableSection.h
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/TableCellPainter.h
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/TablePainter.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/TablePainter.h
[add] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/TablePainterTest.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/core/paint/TableSectionPainter.h
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c

commit 6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Dec 06 02:19:53 2016

Revert of Paint collapsed borders of a table as one display item (patchset #4 id:60001 of https://codereview.chromium.org/2502353003/ )

Reason for revert:
Need to think more about performance and improve.

Original issue's description:
> Paint collapsed borders of a table as one display item
>
> This simplifies paint invalidation logic on collapsed border changes.
>
> About performance:
> With this CL we create a big display item on the table containing all
> collapsed border paintings, instead of many small display items on cells.
> This will cause more painting when the display item is invalidated, but
> saves time to handle many cached display items. Perf try jobs [1] show
> that this CL improves performance of one test
> (blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
> and degrade performance of one test
> (blink_perf.paint.large-table-repaint.html)
> and doesn't affect much of performance of other tests.
> Cluster-telemetry run showed no change or slight progression (https://ct.skia.org/chromium_perf_runs/, run 1433)
>
> This is a reland of https://codereview.chromium.org/2430313004, with
>  crbug.com/664887  fixed by force invalidation of collapsed borders on
> layout change.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> BUG= 663208 , 664887 
> TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with changed display item types about collapsed borders)
>
> Review-Url: https://codereview.chromium.org/2430313004
> Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e
> Cr-Original-Commit-Position: refs/heads/master@{#431744}
> Cr-Commit-Position: refs/heads/master@{#436426}

TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 663208 , 664887 

Review-Url: https://codereview.chromium.org/2556633002
Cr-Commit-Position: refs/heads/master@{#436484}

[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table-outer-border-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table-section-repaint-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/border-collapse-change-separate-to-collapse-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-cell-append-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-color-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-width-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-color-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-width-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-color-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-width-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-row-border-width-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-color-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-width-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-tbody-border-width-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize-expected.txt
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.html
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color.html
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.html
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color.html
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.html
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color.html
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/layout/LayoutTableSection.h
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/paint/TableCellPainter.h
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/paint/TablePainter.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/paint/TablePainter.h
[delete] https://crrev.com/d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba/third_party/WebKit/Source/core/paint/TablePainterTest.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/core/paint/TableSectionPainter.h
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

Comment 9 by wangxianzhu@chromium.org, Dec 6 2016 

#7 and #8 don't affect the status of this bug.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f3a24a75d753be1d151dcb825b349218acf34ca

commit 0f3a24a75d753be1d151dcb825b349218acf34ca
Author: ricea <ricea@chromium.org>
Date: Tue Dec 06 04:28:20 2016

Reland of Paint collapsed borders of a table as one display item (patchset #1 id:1 of https://codereview.chromium.org/2556633002/ )

Reason for revert:
This revert seems to have broken paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html  and virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html on many bots. Reverting some more just to be on the safe side.

See for example https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/516

Original issue's description:
> Revert of Paint collapsed borders of a table as one display item (patchset #4 id:60001 of https://codereview.chromium.org/2502353003/ )
>
> Reason for revert:
> Need to think more about performance and improve.
>
> Original issue's description:
> > Paint collapsed borders of a table as one display item
> >
> > This simplifies paint invalidation logic on collapsed border changes.
> >
> > About performance:
> > With this CL we create a big display item on the table containing all
> > collapsed border paintings, instead of many small display items on cells.
> > This will cause more painting when the display item is invalidated, but
> > saves time to handle many cached display items. Perf try jobs [1] show
> > that this CL improves performance of one test
> > (blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
> > and degrade performance of one test
> > (blink_perf.paint.large-table-repaint.html)
> > and doesn't affect much of performance of other tests.
> > Cluster-telemetry run showed no change or slight progression (https://ct.skia.org/chromium_perf_runs/, run 1433)
> >
> > This is a reland of https://codereview.chromium.org/2430313004, with
> >  crbug.com/664887  fixed by force invalidation of collapsed borders on
> > layout change.
> >
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > BUG= 663208 , 664887 
> > TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with changed display item types about collapsed borders)
> >
> > Review-Url: https://codereview.chromium.org/2430313004
> > Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e
> > Cr-Original-Commit-Position: refs/heads/master@{#431744}
> > Cr-Commit-Position: refs/heads/master@{#436426}
>
> TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 663208 , 664887 
>
> Committed: https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c
> Cr-Commit-Position: refs/heads/master@{#436484}

TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 663208 , 664887 

Review-Url: https://codereview.chromium.org/2551963003
Cr-Commit-Position: refs/heads/master@{#436521}

[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table-outer-border-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table-section-repaint-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/border-collapse-change-separate-to-collapse-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-cell-append-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-color-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-width-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-color-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-width-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-color-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-width-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-row-border-width-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-color-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-width-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-tbody-border-width-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize-expected.txt
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.html
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.txt
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color.html
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.html
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.txt
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color.html
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.html
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.txt
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color.html
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/layout/LayoutTableSection.h
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/TableCellPainter.h
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/TablePainter.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/TablePainter.h
[add] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/TablePainterTest.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/core/paint/TableSectionPainter.h
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7a2bfbdbba8f894de633559bf89f77f35257c9b

commit e7a2bfbdbba8f894de633559bf89f77f35257c9b
Author: ricea <ricea@chromium.org>
Date: Tue Dec 06 09:03:11 2016

Revert of Paint collapsed borders of a table as one display item (patchset #1 id:1 of https://codereview.chromium.org/2551963003/ )

Reason for revert:
Tests break when this patch is out, but more break when it's in. Reverting again.

Original issue's description:
> Reland of Paint collapsed borders of a table as one display item (patchset #1 id:1 of https://codereview.chromium.org/2556633002/ )
>
> Reason for revert:
> This revert seems to have broken paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html  and virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html on many bots. Reverting some more just to be on the safe side.
>
> See for example https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/516
>
> Original issue's description:
> > Revert of Paint collapsed borders of a table as one display item (patchset #4 id:60001 of https://codereview.chromium.org/2502353003/ )
> >
> > Reason for revert:
> > Need to think more about performance and improve.
> >
> > Original issue's description:
> > > Paint collapsed borders of a table as one display item
> > >
> > > This simplifies paint invalidation logic on collapsed border changes.
> > >
> > > About performance:
> > > With this CL we create a big display item on the table containing all
> > > collapsed border paintings, instead of many small display items on cells.
> > > This will cause more painting when the display item is invalidated, but
> > > saves time to handle many cached display items. Perf try jobs [1] show
> > > that this CL improves performance of one test
> > > (blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
> > > and degrade performance of one test
> > > (blink_perf.paint.large-table-repaint.html)
> > > and doesn't affect much of performance of other tests.
> > > Cluster-telemetry run showed no change or slight progression (https://ct.skia.org/chromium_perf_runs/, run 1433)
> > >
> > > This is a reland of https://codereview.chromium.org/2430313004, with
> > >  crbug.com/664887  fixed by force invalidation of collapsed borders on
> > > layout change.
> > >
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > > BUG= 663208 , 664887 
> > > TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with changed display item types about collapsed borders)
> > >
> > > Review-Url: https://codereview.chromium.org/2430313004
> > > Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e
> > > Cr-Original-Commit-Position: refs/heads/master@{#431744}
> > > Cr-Commit-Position: refs/heads/master@{#436426}
> >
> > TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG= 663208 , 664887 
> >
> > Committed: https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c
> > Cr-Commit-Position: refs/heads/master@{#436484}
>
> TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org,wangxianzhu@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 663208 , 664887 
>
> Committed: https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca
> Cr-Commit-Position: refs/heads/master@{#436521}

TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 663208 , 664887 

Review-Url: https://codereview.chromium.org/2548333003
Cr-Commit-Position: refs/heads/master@{#436547}

[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table-outer-border-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table-section-repaint-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/border-collapse-change-separate-to-collapse-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-cell-append-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-color-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-cell-border-width-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-color-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-col-border-width-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-color-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-colgroup-border-width-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-row-border-width-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-color-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-table-border-width-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-change-tbody-border-width-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-cell-resize-expected.txt
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.html
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-cell-change-collapsed-border-color.html
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.html
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-row-change-collapsed-border-color.html
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.html
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color-expected.txt
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-section-change-collapsed-border-color.html
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-cell-collapsed-border-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-collapsed-border-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/layout/LayoutTableSection.h
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/paint/TableCellPainter.h
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/paint/TablePainter.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/paint/TablePainter.h
[delete] https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e/third_party/WebKit/Source/core/paint/TablePainterTest.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/core/paint/TableSectionPainter.h
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/e7a2bfbdbba8f894de633559bf89f77f35257c9b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
►

Sign in to add a comment