Regression: Blank page is seen after clicking on added exceptions in cookies of chrome://md-settings
Reported by
jshan...@etouch.net,
Nov 14 2016
|
||
Issue descriptionChrome Version : 56.0.2918.0 (Official Build)6015da67bcb535f343caf0f5cff5867d7f4487d8-refs/heads/master@{#431795}-32/64 bit OS: Mac(10.11.6, 10.12.1), Windows (7,8,8.1,10), Linux (14.04 LTS) Pre-condition: Enable 'Site settings with All sites and Site details' from chrome://flags Steps: 1. Launch Chrome and navigate to chrome://md-settings/content/cookies 2. Add exception under 'Block/Allow/Clear on exit', click on the added exception and observe. Actual: Blank page is seen after clicking on added exception. Expected: Blank page should not be seen after clicking on added exception. This is a regression issue broken in M-56, will soon update the bisect info. Good Build : 56.0.2916.0 Bad Build : 56.0.2918.0
,
Nov 14 2016
Using the per-revision bisect providing the bisect results, Good build: 56.0.2916.0 (Revision:431463). Bad build: 56.0.2918.0 (Revision:431795). You are probably looking for a change made after 431464 (known good), but no later than 431465 (first known bad). CHANGE-LOG URL: --------------------------------------- https://chromium.googlesource.com/chromium/src/+log/0643d7f805b69c2fd595540791dc6a62ca195254..273b9672cfbf83ffed8f52a91cb59a6e78a64577 From the CL above, assigning the issue to the concern owner @ mgiuca : ------------------ Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2419413002 Note : Able to reproduce the issue in Ubuntu 14.04, Mac 10.11.6 & Win 10.0.
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cd995297b9948b436e3d7a1656cef284a812bfe commit 7cd995297b9948b436e3d7a1656cef284a812bfe Author: mgiuca <mgiuca@chromium.org> Date: Wed Nov 16 00:35:21 2016 Remove fullscreen from MD Settings internal lists. This fixes a crash when opening All Sites as well as on some other pages, due to fullscreen still being registered as a content setting in some lists despite it having been removed from content settings in r431465. BUG= 664886 ,664905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2501763003 Cr-Commit-Position: refs/heads/master@{#432319} [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/app/settings_strings.grdp [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/browser/resources/settings/site_settings/constants.js [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/test/data/webui/settings/site_details_tests.js [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/test/data/webui/settings/site_list_tests.js [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/test/data/webui/settings/site_settings_category_tests.js [modify] https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js |
||
►
Sign in to add a comment |
||
Comment 1 by jshan...@etouch.net
, Nov 14 2016